Skip to content

Support multiple polytone evm connections on ica client #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Buckram123
Copy link
Collaborator

@Buckram123 Buckram123 commented Apr 24, 2025

This PR aims to add support for multiple polytone connections on ica-client.

Implementation inspired by ibc-client

@Buckram123 Buckram123 requested a review from Kayanski April 24, 2025 11:48
@Buckram123
Copy link
Collaborator Author

Buckram123 commented Apr 24, 2025

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive]
enum IcaChainId {
  Cosmos(TruncatedChainId),
  Evm(u64),
}

@Kayanski @adairrr ?

@Kayanski
Copy link
Contributor

Kayanski commented Apr 28, 2025

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive]
enum IcaChainId {
  Cosmos(TruncatedChainId),
  Evm(u64),
}

@Kayanski @adairrr ?

That's a good idea, Are we using this ICA Client for other purposes than EVM chains though ? Is it necessary to have Cosmos chains in there too ? We do have the IBC Client for that I think already ?
Otherwise, that's a very nice idea to have the ICA client work like the IBC client !

@Buckram123
Copy link
Collaborator Author

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive]
enum IcaChainId {
  Cosmos(TruncatedChainId),
  Evm(u64),
}

@Kayanski @adairrr ?

That's a good idea, Are we using this ICA Client for other purposes than EVM chains though ? Is it necessary to have Cosmos chains in there too ? We do have the IBC Client for that I think already ? Otherwise, that's a very nice idea to have the ICA client work like the IBC client !

You are right, we're only using it for evm chains right now. It could be good to keep it as a multi-chain client as it has more functionality beyond helping evm executions and it is quite different from ibc client: each account controls it's own proxy on remote chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants