Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

379 add avail command #381

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Echomo-Xinyu
Copy link

@Echomo-Xinyu Echomo-Xinyu commented Dec 16, 2022

  • Implements the avail command
  • Include test case for the relevant logic
  • minor reorganization of code base

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 76.23% // Head: 76.07% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (aba93a6) compared to base (a76d905).
Patch coverage: 75.48% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #381      +/-   ##
============================================
- Coverage     76.23%   76.07%   -0.16%     
- Complexity      741      789      +48     
============================================
  Files            94       97       +3     
  Lines          2268     2408     +140     
  Branches        279      330      +51     
============================================
+ Hits           1729     1832     +103     
- Misses          445      453       +8     
- Partials         94      123      +29     
Impacted Files Coverage Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 94.36% <0.00%> (-2.74%) ⬇️
src/main/java/seedu/address/model/TeachersPet.java 88.88% <0.00%> (-2.54%) ⬇️
...c/main/java/seedu/address/model/student/Class.java 86.51% <ø> (-0.99%) ⬇️
...ava/seedu/address/logic/commands/AvailCommand.java 44.44% <44.44%> (ø)
.../java/seedu/address/model/timerange/TimeRange.java 69.23% <69.23%> (ø)
...seedu/address/model/student/UniqueStudentList.java 82.39% <78.02%> (-9.77%) ⬇️
.../seedu/address/logic/parser/TeachersPetParser.java 86.36% <83.33%> (-4.12%) ⬇️
...in/java/seedu/address/logic/parser/ParserUtil.java 92.80% <92.30%> (+1.33%) ⬆️
...seedu/address/logic/parser/AvailCommandParser.java 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

In the previous version, the endTime of the time range can be
overflown to next day while it appears to be a valid time range
by the check. Additional check has been enforced to ensure such
situation shall not happen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant