-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory and disk-space option for create/update actions #7
Conversation
Why are these two "options" and cpu_cores not? |
Because I use the default option for cpu_cores but overwrite it for the other two. Otherwise it would generate naming that is generated from the apidoc param. |
You need this block to remove the default options that are generated. |
7934db4
to
90d7ae2
Compare
option '--disk-space', "Disk space", _('Maximum disk space in GiB'), attribute_name: :option_disk_gb, format: HammerCLI::Options::Normalizers::Number.new | ||
option '--remove-memory-limit', :flag, _('Remove quota limit for memory') | ||
option '--remove-disk-space-limit', :flag, _('Remove quota limit for disk space') | ||
option '--remove-cpu-core-limit', :flag, _('Remove quota limit for CPU cores') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the plural here to be consistent with other mentions? remove-cpu-cores-limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nadja, wording LGTM.
90d7ae2
to
389d837
Compare
389d837
to
f25f964
Compare
I've tested creating a quota and passing LGTM, thanks @nadjaheitmann @maximiliankolb! 🐧 PS: The output looks really great, I like that:
|
No description provided.