Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby version #9

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Update ruby version #9

merged 4 commits into from
Jul 10, 2024

Conversation

m-bucher
Copy link
Member

@m-bucher m-bucher commented May 14, 2024 •
edited
Loading

ruby-3.3

@m-bucher m-bucher force-pushed the update_ruby_version branch 2 times, most recently from 0a8e094 to 46050d3 Compare May 14, 2024 15:58
@m-bucher m-bucher force-pushed the update_ruby_version branch 3 times, most recently from 0224fb1 to 1fcacf5 Compare June 25, 2024 13:19
@m-bucher m-bucher marked this pull request as ready for review June 25, 2024 13:23
@m-bucher m-bucher force-pushed the update_ruby_version branch from 1fcacf5 to 3b0967e Compare June 25, 2024 13:29
sbernhard
sbernhard reviewed Jul 10, 2024
View reviewed changes
sbernhard
sbernhard reviewed Jul 10, 2024
View reviewed changes
sbernhard
sbernhard reviewed Jul 10, 2024
View reviewed changes
@m-bucher m-bucher force-pushed the update_ruby_version branch 3 times, most recently from a018bc2 to c79d77f Compare July 10, 2024 13:32
@m-bucher
Fix require at the beginning
c407339 
Exception: require that are only ran, if the file is called as a
stand-alone program for testing (e.g. ruby debRelease.rb), the requires
that are only needed for that are at the start of the "if program==file" block.
@m-bucher m-bucher force-pushed the update_ruby_version branch from c79d77f to c407339 Compare July 10, 2024 13:45
sbernhard
sbernhard approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you.

@m-bucher m-bucher merged commit c933467 into master Jul 10, 2024
1 check passed
@m-bucher m-bucher deleted the update_ruby_version branch July 10, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernhard sbernhard sbernhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bucher @sbernhard