Skip to content

feat: Add vendor test infrastructure framework#222

Open
ashishsingha wants to merge 1 commit intoARM-software:mainfrom
ashishsingha:vendor_test_infrastructure_framework
Open

feat: Add vendor test infrastructure framework#222
ashishsingha wants to merge 1 commit intoARM-software:mainfrom
ashishsingha:vendor_test_infrastructure_framework

Conversation

@ashishsingha
Copy link

  • Add vendor test numbering scheme in acs_common.h (10000+ range)
  • Add vendor test template and documentation in test_pool/vendor/
  • Add verify_vendor_inf.sh script to check vendor INFs are in sync
  • Update acsbuild.sh to support vendor builds with two-argument syntax
  • Vendor builds auto-verify upstream sync before building

@ashishsingha
Copy link
Author

@chetan-rathore @SrikarJosyula Please review this as well. As mentioned in the commit message, this adds framework for silicon vendors to add tests and build as part of the general ACS framework.

@ashishsingha ashishsingha force-pushed the vendor_test_infrastructure_framework branch from 07ede3d to 3a4e67b Compare January 29, 2026 18:01
 - Add vendor test numbering scheme in acs_common.h (10000+ range)
 - Add vendor test template and documentation in test_pool/vendor/
 - Add verify_vendor_inf.sh script to check vendor INFs are in sync
 - Update acsbuild.sh to support vendor builds with two-argument syntax
 - Vendor builds auto-verify upstream sync before building

Signed-off-by: Ashish Singhal <[email protected]>
@ashishsingha ashishsingha force-pushed the vendor_test_infrastructure_framework branch from 3a4e67b to 7bdf348 Compare January 29, 2026 18:28
@chetan-rathore
Copy link
Contributor

Thanks @ashishsingha for the PR—vendor-specific test addition looks like an interesting feature; we’ll review it and share feedback.

ACS follows a Test Pool → VAL → PAL layered structure (methodology: https://github.com/ARM-software/sysarch-acs/blob/main/docs/bsa/arm_bsa_architecture_compliance_validation_methodology.pdf). If new tests are being added into ACS, we expect there may also be corresponding updates needed in VAL/PAL. Could you please share whether you’ve already built and run the additional tests with the current ACS, and whether any required VAL/PAL changes were integrated into the existing VAL/PAL or compiled separately and linked as external libraries?

@ashishsingha
Copy link
Author

Thanks @ashishsingha for the PR—vendor-specific test addition looks like an interesting feature; we’ll review it and share feedback.

ACS follows a Test Pool → VAL → PAL layered structure (methodology: https://github.com/ARM-software/sysarch-acs/blob/main/docs/bsa/arm_bsa_architecture_compliance_validation_methodology.pdf). If new tests are being added into ACS, we expect there may also be corresponding updates needed in VAL/PAL. Could you please share whether you’ve already built and run the additional tests with the current ACS, and whether any required VAL/PAL changes were integrated into the existing VAL/PAL or compiled separately and linked as external libraries?

Vendors can use this in 2 ways. They may have tests related to their IP that they choose to keep downstream, thus not requiring any modification to the VAL/PAL layers. For cases where someone makes enhancements, I expect users to upstream those changes if they choose not maintain them. I have locally validated both approaches, and I see them working seamlessly.

@ashishsingha
Copy link
Author

Thanks @ashishsingha for the PR—vendor-specific test addition looks like an interesting feature; we’ll review it and share feedback.
ACS follows a Test Pool → VAL → PAL layered structure (methodology: https://github.com/ARM-software/sysarch-acs/blob/main/docs/bsa/arm_bsa_architecture_compliance_validation_methodology.pdf). If new tests are being added into ACS, we expect there may also be corresponding updates needed in VAL/PAL. Could you please share whether you’ve already built and run the additional tests with the current ACS, and whether any required VAL/PAL changes were integrated into the existing VAL/PAL or compiled separately and linked as external libraries?

Vendors can use this in 2 ways. They may have tests related to their IP that they choose to keep downstream, thus not requiring any modification to the VAL/PAL layers. For cases where someone makes enhancements, I expect users to upstream those changes if they choose not maintain them. I have locally validated both approaches, and I see them working seamlessly.

@chetan-rathore Any update on this?

@chetan-rathore
Copy link
Contributor

Hi @ashishsingha,
This will require some time for conclusion, as the PR adds a mechanism to have some tests build as part of xBSA which are not in scope of the xBSA specification. I will keep you updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants