Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs and added QoL features #181

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

MissingReports
Copy link

Changes

  • Made stealable items moveable regardless whether they were in a section or no
    Why: If someone specifically marked a slot as stealable, i see NO reason why this should still be cancelling the event. To move sectioned slots the slot itself has to be stealable, if the gui is stealable but the slot isn't then it won't let you move it

  • Made a new Slot Changed section, which is triggered when a specific slot was changed
    Why: This makes it easier to detect changes. Before, it wasn't even possible to detect when you instantly move an item from your inventory into the GUI. Most of the time, cancelling the event won't do anything in a Slot Changed section. You might think this is useless but it has (for me at least) alot of usecases, such as custom anvil or custom crafting table

  • Some changes to the code
    Why: Some parts were causing a warning because they weren't properly coded, such as if List#size == 0 instead of if List#isEmpty

For the most part, I added stuff to skript-gui. It won't affect others and would be useful in some situations. So I hope this PR get's accepted or added in some way

Fixed some bugs regarding removeable/stealable GUI items
@APickledWalrus
Copy link
Owner

I'll take a look into reviewing this soon, sorry for the delay

@APickledWalrus APickledWalrus changed the base branch from master to dev/1.4.0 August 22, 2024 16:47
@APickledWalrus APickledWalrus added the enhancement New feature or request label Aug 22, 2024
Copy link
Owner

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Here are some of the things that I noticed. Please feel free to reply to any of my comments if you have any questions/thoughts 🙂

@MissingReports
Copy link
Author

Thanks for the contribution! Here are some of the things that I noticed. Please feel free to reply to any of my comments if you have any questions/thoughts 🙂

I have committed the updated code, fixing all the previous mistakes

Copy link
Owner

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just the one change that needs further testing. Other than that, this should be good to go. Thank you for your work!!

Copy link
Owner

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for your work!

@APickledWalrus APickledWalrus merged commit 247b9c3 into APickledWalrus:dev/1.4.0 Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants