Issue 283 #286
Merged
Issue 283 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path resolution on Windows.
philsturgeon
approved these changes
Oct 28, 2022
|
I will see why the CI has broken. |
|
@philsturgeon, please, run the CI again - I'm still trying to understand if the changes are enough to pass the tests pipeline. I'm trying to run the CI locally to check first here if it is going to pass. But, it is my first try with GitHub Actions (I've just run GitLab Runner), so this is another science... |
|
Nearly there @danielfcollier, sorry this is a bit labourious. I'll add you as a collaborator so it will let the checks run qithout manual approval. |
|
Hey @philsturgeon, thanks! I will see, looking forward to solve more issues. |
jcmosc
added a commit
to criteria-labs/json-schema-ref-parser
that referenced
this pull request
Jan 4, 2023
philsturgeon
pushed a commit
that referenced
this pull request
Jan 11, 2023
* Update package-lock.json file
* Fix broken tests in blank.spec.js
Blank binary file was not getting serialized as { type: "Buffer", data: [] }
because read(file) was returning a string instead of Buffer.
* Fix webpack error when running browser tests
Webpack 4 cannot parse module containing optional chaining operator.
See https://stackoverflow.com/questions/59972341/how-to-make-webpack-accept-optional-chaining-without-babel
* Fix tests in invalid.spec.js when running in Chrome
* Change statusCode to status
* Set the --openssl-legacy-provider flag when running browser tests
Recent versions of node upgraded to OpenSSL 3.0, which deprecated some
older crypto hashing algorithms including md4.
Webpack 4 hard codes the use of md4 ins some places, so we have to set this
flag until we can upgrade Webpack.
* Use isomorphic-fetch instead of node-fetch
Browser tests were failing as polyfill.js was loading a node package in a browser context.
* Increase minimum version of node to 17
This was when the --openssl-legacy-provider option was introduced.
Prior versions of node do not recognize this option.
* Add chokidar@3 as an explicit dev dependency
Browser tests are failing in the CI environment with:
chokidar@3: Error: Cannot find module 'chokidar'
Don't know why but this thread might be relevant:
facebook/create-react-app#10811
* Skip test assertion due to conflict on Windows
See also #286
* Explicitly define browsers and plugins in karma.conf.js
* Replace karma-edge-launcher with newer package
philsturgeon
pushed a commit
that referenced
this pull request
Jan 20, 2023
* Update package-lock.json file
* Fix broken tests in blank.spec.js
Blank binary file was not getting serialized as { type: "Buffer", data: [] }
because read(file) was returning a string instead of Buffer.
* Fix webpack error when running browser tests
Webpack 4 cannot parse module containing optional chaining operator.
See https://stackoverflow.com/questions/59972341/how-to-make-webpack-accept-optional-chaining-without-babel
* Fix tests in invalid.spec.js when running in Chrome
* Change statusCode to status
* Set the --openssl-legacy-provider flag when running browser tests
Recent versions of node upgraded to OpenSSL 3.0, which deprecated some
older crypto hashing algorithms including md4.
Webpack 4 hard codes the use of md4 ins some places, so we have to set this
flag until we can upgrade Webpack.
* Use isomorphic-fetch instead of node-fetch
Browser tests were failing as polyfill.js was loading a node package in a browser context.
* Increase minimum version of node to 17
This was when the --openssl-legacy-provider option was introduced.
Prior versions of node do not recognize this option.
* Add chokidar@3 as an explicit dev dependency
Browser tests are failing in the CI environment with:
chokidar@3: Error: Cannot find module 'chokidar'
Don't know why but this thread might be relevant:
facebook/create-react-app#10811
* Skip test assertion due to conflict on Windows
See also #286
* Explicitly define browsers and plugins in karma.conf.js
* Replace karma-edge-launcher with newer package
* Increase default timeout of async tests
* Change package type to module
* Change require/module.exports to import/export in source files
* Delete "use strict" directives from source code
* Update tests to ES modules
* Re-export $RefParser methods as standalone functions
Preserve backwards compatibility
* Make karma config file a .cjs file
Fixes “require() of ES Module …/config.js not supported” error
* Avoid top-level await in path.js
The current configuration of karma uses Webpack 4, which can't parse
modules with top-level await.
* Revert back to __dirname for browser tests
Karma configuration needs to upgrade to Webpack 5 in order to use import.meta.url
* Fix lint issues
* Disable code coverage in CI for now
* Revert "Disable code coverage in CI for now"
This reverts commit f571f0a.
* Replace nyc with c8 to work with ES modules
* Implement a dual CommonJS/ES module package.json
* Hack to allow $RefParser to be imported from require() without .default property
Without this hack, you would have to do this:
const $RefParser = require("@apidevtools/json-schema-ref-parser).default;
Now you can do this:
const $RefParser = require("@apidevtools/json-schema-ref-parser);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #283
The problem has been solved by working only with absolute paths on Windows.
Currently, there are 252 passing tests on Windows and 254 passing tests on Linux (probably MacOS too).
Some tests at:
have been fixed to work on any OS or skipped due to conflicts on Windows (error messages that still keeps the
\\from Windows.)Three tests at
test/specs/http.spec.jshave been skipped and it might require opening another issue to investigate further.