Skip to content

feat: add --download-threads / -t arg to control download threads #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2025
Merged

feat: add --download-threads / -t arg to control download threads #413

merged 4 commits into from
May 2, 2025

Conversation

eatradish
Copy link
Member

No description provided.

@eatradish eatradish force-pushed the add-download-threads-arg branch from ba55e72 to 0dbf760 Compare April 30, 2025 08:05
@eatradish eatradish changed the title feat: add --download-threads arg to control download threads feat: add --download-threads / -t arg to control download threads Apr 30, 2025
@eatradish eatradish force-pushed the add-download-threads-arg branch 3 times, most recently from e93b622 to c568bf1 Compare April 30, 2025 09:09
@eatradish eatradish force-pushed the add-download-threads-arg branch from c568bf1 to b2742b3 Compare April 30, 2025 09:11
MingcongBai
MingcongBai approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@MingcongBai MingcongBai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good with:

  • Thread count -1 (read as parameter).
  • Thread count 1.1 (not allowed).
  • Thread count 1 (good), 8 (good), 255 (good), 256 (not allowed).
  • None specified (uses configuration).

@MingcongBai
Copy link
Member

Well, maybe this could be improved:

mingcongbai@JellyNote [ oma@add-download-threads-arg ] $ ./target/release/oma upgrade -t 1.1
error: invalid value '1.1' for '--download-threads <DOWNLOAD_THREADS>': invalid digit found in string

For more information, try '--help'.

@eatradish eatradish merged commit d657388 into master May 2, 2025
8 checks passed
@eatradish eatradish deleted the add-download-threads-arg branch May 2, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MingcongBai MingcongBai MingcongBai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eatradish @MingcongBai