Repository navigation
Rename tones_100ms_3OA_stereo_opus to 1OA and correct its README row - #109
Merged
jwcullen merged 2 commits intoOct 1, 2026
Merged
Conversation
The README described `tones_100ms_3OA_stereo_opus.iamf` as third-order ambisonics plus stereo with 18 tones. The file has two audio elements: a scene-based element in mono mode with ambisonics order 1 (4 channels, 4 substreams) and a stereo channel-based element. The tone frequencies were measured with a zero-padded FFT of each decoded channel: ACN 0 111 Hz, ACN 1 222 Hz, ACN 2 333 Hz, ACN 3 444 Hz, L 8888 Hz, R 9999 Hz. The filename is unchanged. The CMake builder action (`.github/actions/iamf-tools-cmake-builder/action.yml`) runs `probe_main` on this file by name.
Collaborator
|
Let's just change the filename to have "1OA", otherwise it's misleading. That cmake build is the only reference, and it seems safe to change it there too. |
Contributor
Author
|
Makes sense, thanks @jwcullen ! Will do that. |
…s.iamf The scene-based audio element in the file has ambisonics order 1, so the "3OA" in the name was wrong. Update the README row and the CMake builder action (`.github/actions/iamf-tools-cmake-builder/action.yml`), which runs `probe_main` on the file by name.
trsonic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README described
tones_100ms_3OA_stereo_opus.iamfas third-order ambisonics plus stereo with 18 tones. The file has two audio elements: a scene-based element in mono mode with ambisonics order 1 (4 channels, 4 substreams) and a stereo channel-based element.The tone frequencies were measured with a zero-padded FFT of each decoded channel: ACN 0 111 Hz, ACN 1 222 Hz, ACN 2 333 Hz, ACN 3 444 Hz, L 8888 Hz, R 9999 Hz.
The file is renamed to
tones_100ms_1OA_stereo_opus.iamf. The CMake builder action (.github/actions/iamf-tools-cmake-builder/action.yml) runsprobe_mainon this file by name and is updated to the new name.