Repository navigation
Apply fixes for aomedia:3113 to libavm - #5506
Merged
Merged
Conversation
Contributor
Author
|
cc @wantehchang who fixed https://crbug.com/aomedia/3113. |
urvangjoshi
self-requested a review
October 8, 2026 16:22
Contributor
|
Thanks for the fix @y-guyon ! Looks good. |
urvangjoshi
approved these changes
Oct 8, 2026
wantehchang
approved these changes
Oct 8, 2026
wantehchang
left a comment
wantehchang
left a comment
Member
There was a problem hiding this comment.
LGTM. I verified my two libaom commits were ported to AVM correctly. (AVM only has the highbd functions, so the changes to the 8-bit functions were not ported.)
I will write a PR to bring the new unit test up to date with the current libaom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://crbug.com/aomedia/3113.
Found with https://github.com/webmproject/CrabbyAvif/blob/main/tests/av2.rs.
Note this is not part of the AOM commits listed at https://gitlab.com/AOMediaCodec/avm/-/work_items/570.