Repository navigation
Fix 1-pass CBR frame dropping and initial I-frame target - #5498
Merged
urvangjoshi merged 1 commit intoOct 6, 2026
Merged
Conversation
urvangjoshi
approved these changes
Oct 6, 2026
Only allow 1-pass CBR frame dropping when lag_in_frames == 0 to avoid dropping overlay/inter frames when lookahead or keyframe filtering is enabled. Also restrict the 7/2 initial buffer scaling for frame 0 in av2_calc_iframe_target_size_one_pass_cbr() to REALTIME mode. Fixes AOMediaCodec#5488
urvangjoshi
force-pushed
the
rtc_fix_test_drop_frame
branch
from
October 6, 2026 00:25
aaa1f2a to
b788a5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only allow 1-pass CBR frame dropping when lag_in_frames == 0 to avoid dropping overlay/inter frames when lookahead or keyframe filtering is enabled. Also restrict the 7/2 initial buffer scaling for frame 0 in av2_calc_iframe_target_size_one_pass_cbr() to REALTIME mode.
Fixes #5488