Repository navigation
Extend intra mode cache reuse to revisited intra blocks - #5484
Merged
Merged
Conversation
chengchen-google
force-pushed
the
s9-b-clean
branch
from
October 2, 2026 21:55
65ac261 to
68970b5
Compare
yeqing-wu
reviewed
Oct 5, 2026
yeqing-wu
left a comment
Contributor
There was a problem hiding this comment.
@chengchen-google, thanks for the efforts, I have two comments, could you please help take a look?
chengchen-google
force-pushed
the
s9-b-clean
branch
from
October 6, 2026 23:39
68970b5 to
0449da4
Compare
yeqing-wu
approved these changes
Oct 7, 2026
yeqing-wu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @chengchen-google, LGTM.
1. Reuse cached intra modes (x->inter_mode_cache[0]) on revisited blocks within the same superblock pass in av2_rd_pick_intra_sby_mode() and av2_rd_pick_intra_sbuv_mode() when REUSE_INTRA_MODE_IN_INTERFRAME_FLAG is active, restricting search to the cached winning mode and DC_PRED. 2. Skip redundant IntraBC search in av2_rd_pick_intra_mode_sb() when the cached mode on a revisited sub-block did not use IntraBC. Performance on RA, A1 (17 frames), A2 (33 frames) against the baseline commit: 24ff468 ``` Speed Bar BD-rate PSNR-YUV Enc_Speedup Ratio (A1 / A2) 1 ≥35 +0.13% 7.80% 52.0 / 60.0 (PASS) 2 ≥30 +0.10% 2.50% 31.3 / 25.0 (PASS) 3 ≥25 +0.06% 2.98% 33.1 / 49.7 (PASS) 4 ≥20 +0.07% 4.69% 46.9 / 67.0 (PASS) 5 ≥15 +0.12% 3.88% 29.8 / 32.3 (PASS) 6 ≥10 +0.14% 2.75% 18.3 / 19.6 (PASS) ``` STATS_CHANGED Change-Id: I88a0eb283f7b11943cc8b24a6173d64ab87f2dca
chengchen-google
force-pushed
the
s9-b-clean
branch
from
October 7, 2026 02:38
0449da4 to
31d3752
Compare
yunqingwang1
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance on RA, A1 (17 frames), A2 (33 frames) against the baseline commit: 24ff468
STATS_CHANGED