Off state when motor power is off

[HEnquist]

This changes the state of each axis to Off when the motor power is off.

This relates to this change in the sardana docs: https://gitlab.com/sardana-org/sardana/-/commit/69c0c7ffc2863dd2d9b76344df119186d02684c0

[reszelaz]

I would still not merge it. There is an issue in Sardana when one power on/off the motor - see my tests .

I also propose to return False in the PreStartOne() method when there is no power.

[rhomspuron]

@reszelaz if the motor is off, the current state is Alarm, should it return False on the PreStartOne anyway?

[reszelaz]

@reszelaz if the motor is off, the current state is Alarm, should it return False on the PreStartOne anyway?

The client is still able to request the move if the motor is in Alarm. Then the PreStartOne() returning False will prevent to actually sent the request to the hardware. DummyMotorController implements it like this.

[aureocarneiro]

Hi @reszelaz , @rhomspuron, I want to resurrect this PR, can you continue the review ?

[ajoubertza]

LGTM

[rhomspuron]

Hi @reszelaz,

In your test you reported that the Taurus widget does not work fine, is it solved?

Roberto

[reszelaz]

Hi @aureocarneiro , @ajoubertza, @rhomspuron

I just opened https://gitlab.com/sardana-org/sardana/-/issues/1809 in Sardana to try to unblock this MR: it would help if you comment there with your experince about other motion controllers.