Allow to memorize PMUX ctrl attribute and SyncAux/SyncPos/SyncRes axis attributes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax to set the PMUX value is: PMUX [HARD] [POS] [AUX] <source> [<dest>] The controller returns something like "PMUX POS AUX B5 R1" as read value but doesn't allow to pass that string as set value. Until now, "POS AUX B5 R1" was supposed to be used. This change allows to pass as well the read value starting with "PMUX" (it will be ignored).
SyncAux/SyncPos/SyncRes were defined as list of strings. Spectrum can't be memorized. Convert them to space separated strings instead.
|
Hi @beenje, Sorry for the delay, thanks for do it :). I reviewed the PR and it looks great. I would like to be sure that we do not use this attributes before change the API. Anyway we can integrate it and change the major version Roberto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMUXwas already set as string and could be memorised, but:PMUXstring wasn't allowed in the set value, which I found confusing when looking at the read value, which returns something likePMUX POS AUX B5 R1. That couldn't be used as set value. Only something likePOS AUX B5 R1was accepted (withoutPMUX). Both syntax can now be used.PMUX POS B5 R0, PMUX AUX B1 E0. The controller now accepts multiple comma separated commands as set value (i.e.PMUX POS B5 R0, PMUX AUX B1 E0).SyncAux/SyncPos/SyncReswere defined as list of strings (spectrum), which can't be memorised. Replace them with strings instead (space separated) so they can be memorised.