ci: fix invalid ci.yml so the workflow loads again#110
Merged
Conversation
CI has failed to load ("workflow file issue", 0 jobs) on every push/PR
since these YAML errors landed, so no flopscope PR can get CI. Three
defects in .github/workflows/ci.yml:
1. invalid top-level `timeout-minutes: 240` (not a valid top-level key;
each job already sets its own).
2. unquoted colons in 8 "NumPy compat: ..." step names
(YAML: mapping values are not allowed here).
3. flush-left heredoc Python in the ci-cost-report run block, ending the
block scalar early; re-indented to the block level (YAML strips it, so
the shell still receives flush-left content + the PY terminator).
Validated with PyYAML: parses cleanly, all 10 jobs intact, no logic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flopscope CI has been failing to load ("workflow file issue", 0 jobs) on every push/PR since these YAML errors landed — so no flopscope PR can get CI. Three defects in
.github/workflows/ci.yml:timeout-minutes: 240— not a valid top-level GitHub Actions key (each job already sets its own).NumPy compat: …step names →mapping values are not allowed here.ci-cost-reportjob'srun: |block → terminates the block scalar early. Re-indented to the block level (YAML strips it back, so the shell still receives flush-left content + thePYterminator).Validated with PyYAML: the file now parses cleanly, all 10 jobs intact, no logic changes.
Please merge this first
CI is self-blocked (the broken workflow can't run to validate its own fix), so this needs review-and-merge on inspection. Once it's on
main, CI is restored repo-wide and the feature PR (#109) — plus everything else — will run.