Refactor - Addresses (usages) #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful when I go through and add descriptive errors to everything everywhere
This allows other structs which wrap a fixed-length byte array to simply use it as a field, and not have to deal with any of the details of formatting or JSON hex (de)serialization.
this makes it clear which serialization format is being used where, as we are going to be changing this up soon
This will enable us to keep JSON serialization separate from the binary encoding, and also be much more explicit about the exact binary representation of objects.
# Conflicts: # src/utils/mod.rs
Also implemented PlaceholderIndexed for all crypto structs
P2SH doesn't work yet, I don't want it to exist at all for the time being
# Conflicts: # src/utils/transaction_utils.rs
…ages # Conflicts: # src/script/interface_ops.rs # src/script/lang.rs # src/utils/transaction_utils.rs
…ess-version # Conflicts: # src/utils/transaction_utils.rs
…ages # Conflicts: # src/utils/script_utils.rs # src/utils/transaction_utils.rs
|
Okay this one is on the scarier side in terms of breaking changes. These will be the edge cases that need to be fully verified before we can merge in:
Number 1 is a must. Number 2 would be ideal, bordering on a must as well |
This was referenced Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #49 (
addresses), #44 (disable-p2sh), and #51 (no-address-version).This changes most of the existing transaction-related structs and code to use the dedicated address structs added in #49 instead of raw strings.
Changelog
TxOut'sscript_public_keyfromStringtoAnyAddressDefaulttrait fromTxOut, with minor associated changesDruidExpectation'stofromStringtoAnyAddressDefaulttrait fromDruidExpectationandDdeValues, with no side effectsDruidExpectation'sfromfromStringtoTxInsAddressReceiverInfo'saddressfromStringtoAnyAddressString/&strType of Change
Please mark the appropriate option by putting an "x" inside the brackets:
Checklist
Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!
Screenshots (if applicable)
If the changes affect the UI or have visual effects, please provide screenshots or GIFs showcasing the changes.
Additional Context (if applicable)
Add any additional context or information about the changes that may be helpful in understanding the pull request.
Related Issues (if applicable)
If this pull request is related to any existing issues, please list them here.
Requested Reviewers
Mention any specific individuals or teams you would like to request a review from.