Skip to content

Add MaxText Llama 3.1 70B training with GCS recipe #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raymondzouu
Copy link
Collaborator

No description provided.

Copy link

@mkmg mkmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raymondzouu raymondzouu force-pushed the storage-recipe branch 4 times, most recently from f8dcddc to 51d9cee Compare April 10, 2025 00:19
@@ -0,0 +1,11 @@
python3 benchmarks/benchmark_runner.py xpk \
project=$PROJECT \
zone=$ZONE \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need the .sh script here. This is not blocking, if you think its needed, go ahead with it.
LGTM.

@raymondzouu raymondzouu force-pushed the storage-recipe branch 2 times, most recently from 2246636 to c568eb0 Compare April 10, 2025 16:32
@raymondzouu raymondzouu requested a review from mkmg April 10, 2025 17:13
Copy link

@mkmg mkmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all those changes; it's looking really good! Just a few more comments, but I think we are close!

@raymondzouu raymondzouu force-pushed the storage-recipe branch 2 times, most recently from f9d5280 to 9f57b66 Compare April 10, 2025 19:32
@raymondzouu raymondzouu requested a review from mkmg April 10, 2025 19:33
Copy link

@mkmg mkmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the last few comments, but overall LGTM! Thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants