-
Notifications
You must be signed in to change notification settings - Fork 14
Add MaxText Llama 3.1 70B training with GCS recipe #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
698777c
to
57ff296
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
training/trillium/Llama3.1-70B-MaxText-with-Storage/checkpoint_pvc.yaml
Outdated
Show resolved
Hide resolved
training/trillium/Llama3.1-70B-MaxText-with-Storage/dataset_pvc.yaml
Outdated
Show resolved
Hide resolved
training/trillium/Llama3.1-70B-MaxText-with-Storage/dataset_pvc.yaml
Outdated
Show resolved
Hide resolved
training/trillium/Llama3.1-70B-MaxText-with-Storage/dataset_pvc.yaml
Outdated
Show resolved
Hide resolved
...ning/trillium/Llama3.1-70B-MaxText-with-Storage/llama3-1-70B-real-data-and-ckpt-1xv6e-256.sh
Outdated
Show resolved
Hide resolved
f8dcddc
to
51d9cee
Compare
@@ -0,0 +1,11 @@ | |||
python3 benchmarks/benchmark_runner.py xpk \ | |||
project=$PROJECT \ | |||
zone=$ZONE \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we need the .sh script here. This is not blocking, if you think its needed, go ahead with it.
LGTM.
training/trillium/Llama3.1-70B-MaxText-with-Storage/dataset_pvc.yaml
Outdated
Show resolved
Hide resolved
training/trillium/Llama3.1-70B-MaxText-with-Storage/checkpoint_pvc.yaml
Outdated
Show resolved
Hide resolved
2246636
to
c568eb0
Compare
c568eb0
to
fe2b53f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all those changes; it's looking really good! Just a few more comments, but I think we are close!
f9d5280
to
9f57b66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the last few comments, but overall LGTM! Thanks for your work on this!
9f57b66
to
e52b1b8
Compare
e52b1b8
to
4aea327
Compare
No description provided.