-
Notifications
You must be signed in to change notification settings - Fork 433
Docs: Improve TPU Runtime & Colab setup guide #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
002af5e to
1ffa78b
Compare
docs/tutorials/how_to_run_colabs.md
Outdated
|
|
||
| - **`rl_llama3_demo.ipynb`** → GRPO/GSPO training on math dataset (Colab/notebook) | ||
|
|
||
| #### GRPO/GSPO Colab Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required, please remove this section.
7635807 to
cc876b5
Compare
|
|
||
| - **`rl_llama3_demo.ipynb`** → GRPO/GSPO training on math dataset (Colab/notebook) | ||
|
|
||
| #### GRPO/GSPO Colab Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, do you mean I should also remove the 'GRPO/GSPO Python Script Usage - local runs' and 'cluster runs' sections as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because that is irrelevant to this documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Removed.
1474f2e to
a78bf5c
Compare
…ng notebooks and connecting to local Jupyter Lab.
a78bf5c to
f2cb1af
Compare
Description
Updates the Jupyter/Colab documentation to resolve setup friction and connection errors identified during testing.
Key Changes:
Colab (Method 1): Clarified the workflow to open notebooks directly from GitHub to avoid file import confusion.
TPU VM (Method 2): Moved SSH tunneling to the initial connection step. This fixes the issue where users faced connection failures by attempting to access Jupyter before the tunnel was active.
GRPO/GSPO: Added specific open/setup instructions for running RL demos in both environments.
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/463414427
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
I manually verified the updated instructions to ensure accuracy:
sft_qwen3_demo.ipynbinto a fresh Colab session.v5e-8TPU VM.-L 8888:localhost:8888).localhostlink worked immediately without needing a separate tunnel step.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.