Set check_vma true for moe sparse matmul #2745
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
check_vma=Truefor the sparse_matmul shard_map, and remove some unnecessaarypsum, which are backward transpose ofjax.lax.pvary, see jax doc.This PR currently only supports pure FSDP + megablox kernel.
Following tests are outdated.
Performance Improvements
Test Case 1: Deepseek-test(small) + ZeRO1 + GA
Test Case 2: Deepseek3-test Model
Test Case 3: Deepseek2-16b on v5p-32 Cluster
Test Case 4: Deepseek3-671b on tpu7x-512
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.