Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyink
had 130k downloads last month whereasruff
had 89M.ruff
is faster—being written in Rust—and has more configuration options. All the Python communities are switching to this. In the future; and this PR sets the groundwork; would like to switch toruff
overpylint
for lint checking also. After that either Rust-writtenty
(same folks asruff
) or Pyrefly from Meta for type checking; as thepytype
we've been using is deprecated (see google/pytype/issues/1838).Related: #2210
As you can see the code has changed a little, because it takes indentation seriously. You want two-spaces? - Then that will be enforced throughout. Personally I prefer 4 spaces, but it seems that Google takes 2 spaces religiously so that's what this enforces.
PS: Rather than updating in this PR, can we just remove code_style.sh now that we have proper pre commit hooks?
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-review
label.