Skip to content

Migrate Gemma3DecoderLayer and Gemma3ScannableBlock to NNX #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

Migrate Gemma3DecoderLayer and Gemma3ScannableBlock to NNX #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MaxText/layers/decoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ def get_decoder_layers(self):
case DecoderBlockType.GEMMA2:
return [gemma2.Gemma2DecoderLayer]
case DecoderBlockType.GEMMA3:
return [gemma3.Gemma3DecoderLayer]
return [gemma3.Gemma3DecoderLayerToLinen]
case DecoderBlockType.GPT3:
return [gpt3.Gpt3DecoderLayer]
case DecoderBlockType.GPT_OSS:
Expand Down Expand Up @@ -871,7 +871,7 @@ def _apply_gemma3_scanned_blocks(
scan_length = cfg.num_decoder_layers // attention_pattern_length

policy = self.get_remat_policy()
RemattedGemma3Block = self.set_remat_policy([gemma3.Gemma3ScannableBlock], policy)[0]
RemattedGemma3Block = self.set_remat_policy([gemma3.Gemma3ScannableBlockToLinen], policy)[0]

layer_call_kwargs = {"bidirectional_mask": bidirectional_mask}
layer_kwargs = {"num_of_layers": attention_pattern_length}
Expand Down
Loading
Loading