Skip to content

Test notify changes #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/RunTests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,17 +146,22 @@ jobs:
- name: Delete TPU image
run: gcloud container images delete gcr.io/tpu-prod-env-multipod/maxtext_${{ github.run_id }}:tpu --force-delete-tags --quiet

notify:
if: ${{ always() }}
notify_success:
if: ${{ success() }}
name: Notify successful build
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests]
runs-on: ubuntu-latest
steps:
- name: Log message if dependent job succeeded
run: echo "Conditions for creating/updating issue not met. Skipping."

notify_failure:
if: ${{ failure() && github.event.pull_request == null}}
name: Notify failed build # creates an issue or modifies last open existing issue for failed build
needs: [cpu_unit_tests, gpu_unit_tests, gpu_integration_tests, tpu_unit_tests, tpu_integration_tests]
runs-on: ubuntu-latest
steps:
- name: Check whether one of the jobs failed
if: ${{ failure() && github.event.pull_request == null }}
uses: jayqi/failed-build-issue-action@1a893bbf43ef1c2a8705e2b115cd4f0fe3c5649b # v1.2.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: Log message if dependent job succeeded
if: ${{ ! (failure() && github.event.pull_request == null) }}
run: echo "Conditions for creating/updating issue not met. Skipping."
3 changes: 1 addition & 2 deletions .github/workflows/run_tests_internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,5 @@ jobs:
- uses: actions/checkout@v4
- name: Run Tests
run: |
python3 -m pip install -e . --no-dependencies &&
python3 -m pytest -v --pyargs MaxText.tests -m '${{ inputs.pytest_marker }}' --durations=0
python4

Loading