-
Notifications
You must be signed in to change notification settings - Fork 366
Enable Checkpoint Conversion from Huggingface to Maxtext #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, thanks for adding such a feature!
Hi @gagika ! I've heard this might be interesting to you for loading/saving HF checkpoints. Would you like to take a look when you got a chance? Thanks a lot for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yixuan! Added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! I have 1 small comment and also a question -- did you test both directions -- to and from HF ? if so can you add both to the PR description testing section, currently it includes 1 example. Thanks!
limitations under the License. | ||
""" | ||
|
||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify what's the difference between this file and forward_pass_logits_checker ? this file is used in all our end-to-end tests to verify logits. If there is something missing in that file, I wonder if we could change it rather than creating a new file ?
from HF conversion with examples is pushed in previous PR: #1785 and #1821. And I have revised the run name. |
Description
Enable checkpoint conversion from Huggingface to Maxtext.
Tests
The converted checkpoint is tested with mt_hf_mutual_conversion_check.py. It compared:
Tested on Gemma2-2b Model. A successful conversion example.
Checklist
Before submitting this PR, please make sure (put X in square brackets):