Incorporate Orbax emergency replicator checkpoint manager #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuefgu
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla and
RissyRan
as code owners
Incorporate Orbax emergency replicator checkpoint manager Incorporate Orbax emergency replicator checkpoint manager Incorporate Orbax emergency replicator checkpoint manager
gobbleturk
approved these changes
Jan 9, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
PiperOrigin-RevId: 713747744
parambole
requested review from
yangyuwei,
parambole,
richjames0,
gagika,
shralex,
SurbhiJainUSC,
hengtaoguo,
A9isha and
aireenmei
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporate Orbax emergency replicator checkpoint manager.
It is a feature under test and does not affect any other usage of MaxText.
Tests
Manually tested and observed that the behavior is WAI: local checkpoints are saved on each slice and no GCS checkpoints are saved.
To-be-tested: The restore path with the relevant GKE component. We agreed that we would first check in the code for the save path and leave E2E for later.
Checklist
Before submitting this PR, please make sure (put X in square brackets):