-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor readme #41
Refactor readme #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will let @gangji decide how we showcase the engines. If we need to make this change, shall we add the maxtext user guide to /docs/tutorials/online-inference-with-maxtext-engine.md
. Similarly, we could also add /docs/tutorials/online-inference-with-pytorch-engine.md
here.
Move maxtext to '/docs/tutorials/' sound reasonable. Ideally, I feel the user guide can be owned by maxtext. |
In general, having a docs folder is a great idea. I am also a fan of keeping tests/docs close to the code. Also, having multiple source of truths might cause maintenance overhead. One solution is link to the https://cloud.google.com/tpu/docs/tutorials/LLM/jetstream. Open to suggestions. Thanks! |
Agree with Fanhai's change. In principle: |
I feel we need two docs: 1: official doc for release version, this is the "https://cloud.google.com/tpu/docs/tutorials/LLM/jetstream" 2: Latest doc with current git code, this one we could use the git readme, the latest change also been updated to readme, but not to official doc as it's not release yet. In current PR, I keep both git readme and the office doc. The overhead maintenance is minor, anyway engineer need to update the readme with change together if the change either brings new feature or current readme doesn't reflect the code (i.e. Zijun recent dns server address to ip change) |
cc @vipannalla. |
Agree with others, we need separate doc folders. JetStream main README should focus on engine APIs and how to make it easy for anyone to write their own engine. We should just have links to Jetstream-Pytorch and MaxText as reference implemtations. |
README.md
Outdated
|
||
There are two engine implementation - Jax and Pytorch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Currently, there are two reference engine implementations available -- one for Jax models and another for Pytorch models."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changed.
@@ -0,0 +1,289 @@ | |||
# JetStream MaxText Inference on v5e Cloud TPU VM User Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should really be in MaxText repo, similar to pytorch one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should really be in MaxText repo, similar to pytorch one.
We can do it later (after separation maxtext training vs inference ), there is no place I can put in maxtext repo right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
* Reafactor readme * update README * Update README.md
This RP refactor readme to make it more clear. Here is are several principle for the refactor: