Fix chunked prefill regression #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyanpeng-google
requested review from
mailvijayasingh and
vipannalla
and removed request for
vipannalla
mailvijayasingh
approved these changes
Mar 26, 2025
mailvijayasingh
approved these changes
Mar 26, 2025
Fix typo expand to correct batch dimension Remain the chunk size with bos Add chunked prefill define in engine api
yuyanpeng-google
force-pushed
the
yuyan-fix-chunked-prefill
branch
from
3f9443a to
35a54b7
Compare
Collaborator
Author
|
Rewrite chunked prefill in orchestrator unitest later. |
mailvijayasingh
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo of expanding wrong dimension.
Fix calculate wrong position and true length due to bos.
Test by benchmark servering