Skip to content

JetStream changes for Jax based implementation of unified_lora_params for decoding batch of multiple different lora adapters. #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

aman2930
Copy link
Collaborator

@aman2930 aman2930 commented Mar 7, 2025

JetStream changes for Jax based implementation of unified_lora_params for decoding batch of multiple different lora adapters.

@aman2930 aman2930 requested a review from vipannalla as a code owner March 7, 2025 16:53
@aman2930 aman2930 requested a review from yixinshi March 7, 2025 16:58
Base automatically changed from amangu-lora to main April 14, 2025 18:58
…ms for decoding batch of multiple different lora adapters.

- Creating a cache with first dimension equals to the number of slots and holding the adapter_weights for inference at that slot.
- Added functionality to have different scale factor for different adapters in a batch.
@aman2930 aman2930 requested a review from jyj0w0 May 22, 2025 15:31
Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions github-actions bot added the pull ready This label is needed if we want the copybara service to auto sync it to g3. label May 23, 2025
@copybara-service copybara-service bot merged commit 261f250 into main May 23, 2025
6 checks passed
@copybara-service copybara-service bot deleted the amangu-lora-3 branch May 23, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready This label is needed if we want the copybara service to auto sync it to g3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants