assistant/add default genre #944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosannamilner
changed the title
Sallaa
reviewed
Oct 1, 2025
| credibilitySignal === subjectivityTitle | ||
| ) { | ||
| filteredCategories[label] = classification[label]; | ||
| } else if (credibilitySignal === keyword("news_genre_title")) { |
There was a problem hiding this comment.
The PR looks good. I am just wondering, do these keyword checks still work if the user changes the language?
We had some issue doing checks with the keyword function elsewhere, and we now do checks based on the keyword labels only e.g. checking if ... === "news_genre_title". Maybe changing the language doesn't break things here though
There was a problem hiding this comment.
It behaves as expected across different languages checking the keywords like this, but I'm happy to create a new issue and swap these across the assistant to if ... === "news_genre_title" just to be safe?
I have just changed keyword("news_genre_title") to the constant newsGenreTitle here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having chatted to Olesya about how the news genre classifier behaves, she recommends having a default genre always set. This will be "Reporting" ("Objective reporting" seen by users). If "Satire" or "Opinionated news" return with a score higher than a threshold, then the relevant label will be displayed instead.
Added separate threshold for news framing (0.8) and news genre (0.7)