Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant UI updates #601

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Assistant UI updates #601

merged 9 commits into from
Oct 1, 2024

Conversation

rosannamilner
Copy link
Collaborator

@rosannamilner rosannamilner commented Sep 17, 2024

General

  • Removed extra unnecessary cards and dividers
  • added missing warning statuses

Updated form

  • Changed URL form to use submit button only
  • Changed display for File Selected

Improved footer and moved to new file

  • added translate, copy and expand/minimise buttons
  • added detected language in full

Credibility Signals

  • added new footers
  • corrected previous fact check behaviour when none returned

Extracted URLs

  • open in new tab not same window
  • aligned loading symbol with warning/mention/positive credibility icons

Media card

  • using full width

@Sallaa Sallaa self-requested a review September 23, 2024 12:13
@Sallaa
Copy link
Contributor

Sallaa commented Sep 23, 2024

Thank you for the changes, the interface looks much better / cleaner already.

It looks like there is a display issue with the submit button in the form when the window is resized to a smaller width

Screenshot 2024-09-23 at 14 13 12

@rosannamilner
Copy link
Collaborator Author

Thank you for the changes, the interface looks much better / cleaner already.

It looks like there is a display issue with the submit button in the form when the window is resized to a smaller width

Screenshot 2024-09-23 at 14 13 12

Thanks for spotting! I have changed to use Stack instead of Grid2 which has solved this problem. I have also fixed two bugs I spotted in AssistantCredibilitySignals.jsx related to the new text footer. This is ready to be merged now if you're happy.

Copy link
Collaborator

@twinkarma twinkarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the UI definitely looks a lot cleaner!

@Sallaa Sallaa merged commit d215d0a into beta-master Oct 1, 2024
1 check passed
@Sallaa Sallaa deleted the assistant/update-ui-results branch October 3, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants