Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant/credibility signals fix accordion #585

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

rosannamilner
Copy link
Collaborator

Fixed accordion internal minimise/maximise button to be less confusing (re https://github.com/orgs/GateNLP/projects/15/views/1?pane=issue&itemId=77460421):
image

  • looks like big changes in diff for AssistantCrediblitySignals.jsx because of removing unnecessary outer Grid2 in return, so indentation has changed
  • MUI6 issue of accordion summaries not lining up from Grid to Grid2 change fixed

Errors:

  • error when scope not existing, changed to checking for scope
  • console error: Warning: Received 'true' for a non-boolean attribute 'button'., corrected this

@Sallaa Sallaa merged commit 651b753 into beta-master Sep 13, 2024
1 check passed
@rosannamilner rosannamilner deleted the assistant/credibility-signals-fix-accordion branch September 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants