-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding credibility signals feature #562
Conversation
Add assistant text classifier UI with html formatting first commit added new sagas starting to add accordion display Displaying gcloud cred signals tidied up list of genre, topic, persuasion added typography machince generated text service added fixed subjectivity displaying subjective sentences displaying correct subjective sentences tidied display of credibillity signals using stored secrets for kinit services removed classifiers from URL test box added code for checking logged in for pfc preventing pfc from being called if not logged in removing unnnecessary imports adding subj tooltip and pfc limit refactored credibility signals added messages for after logging in login message and passing text to semantic search as variable captialised genres added assistant.json text moved tooltips out to cardheader pfc and mgt sagas work after login typos added comments added embedding message moved credsignals grid to correct card removed console.log message removed unnecessary tooltip log moved text to assistant.json tidied code counting categories in wrapfunc counting categories in wrapfunc change
Add assistant text classifier UI with html formatting first commit added new sagas starting to add accordion display Displaying gcloud cred signals tidied up list of genre, topic, persuasion added typography machince generated text service added fixed subjectivity displaying subjective sentences displaying correct subjective sentences tidied display of credibillity signals using stored secrets for kinit services removed classifiers from URL test box added code for checking logged in for pfc preventing pfc from being called if not logged in removing unnnecessary imports adding subj tooltip and pfc limit refactored credibility signals added messages for after logging in login message and passing text to semantic search as variable captialised genres added assistant.json text moved tooltips out to cardheader pfc and mgt sagas work after login typos added comments added embedding message moved credsignals grid to correct card removed console.log message removed unnecessary tooltip log moved text to assistant.json tidied code counting categories in wrapfunc counting categories in wrapfunc change counting categories in wrapfunc change Subjectivty confidence colour blue refactoring pertech code refactor for correct persuasion techniques added/removed comments updated tooltip text remove console.log fixes for persuasion techniques fixes for subjectivity edited keyword for semantic search changed mgt.pred to use keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestion for changes but overall looking really good! Great work!
src/components/NavItems/Assistant/AssistantScrapeResults/AssistantTextSpanClassification.jsx
Outdated
Show resolved
Hide resolved
src/components/NavItems/Assistant/AssistantScrapeResults/AssistantTextClassification.jsx
Outdated
Show resolved
Hide resolved
src/components/NavItems/Assistant/AssistantApiHandlers/useAssistantApi.jsx
Outdated
Show resolved
Hide resolved
...components/NavItems/Assistant/AssistantCheckResults/ExtractedSourceCredibilityDBKFDialog.jsx
Outdated
Show resolved
Hide resolved
...components/NavItems/Assistant/AssistantCheckResults/ExtractedSourceCredibilityDBKFDialog.jsx
Outdated
Show resolved
Hide resolved
...components/NavItems/Assistant/AssistantCheckResults/ExtractedSourceCredibilityDBKFDialog.jsx
Outdated
Show resolved
Hide resolved
...components/NavItems/Assistant/AssistantCheckResults/ExtractedSourceCredibilityDBKFDialog.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ab/verification-plugin into assistant/credibility-signals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a check for Arabic (and LTR languages) but the rest looks good to me 👍
Please merge beta-master
into your branch to also fix the conflicts
src/components/NavItems/tools/SemanticSearch/components/ResultDisplayItem.jsx
Outdated
Show resolved
Hide resolved
src/components/NavItems/tools/SemanticSearch/components/ResultDisplayItem.jsx
Outdated
Show resolved
Hide resolved
Thanks Valentin - noticing I don't have the languages drop down menu at the top, it appears empty and I'm struggling to work out why it's not appearing. (Checked for this branch and same on beta-master). Do you have any ideas why this could be happening? Looking into components/Navitems/languages/languages.jsx, storeLanguage prints out as "en" but languageList is empty. |
@rosannamilner this usually happens when you are pointing to the wrong branch or when you are offline (no internet connection) Can you try the following troubleshooting?
Let me know if you still face the issue after this |
Also, let me know if you see error messages in the console. They could indicate where the problem is coming from |
I have done the above with no luck, but I do see these errors in the console:
|
@Sallaa I'm missing REACT_APP_TRANSLATION_URL from my |
This new feature adds six credibility signal classifiers:
Related to AFP-Medialab/InVID-Translations#93