-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Refactoring #551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces (a lot of) refactoring changes regarding the navigation.
The rationale is to have less error-prone code: less hardcoded strings, less arrays all around relying on ids that could break and shift things easily. The new code should be:
So... The first and main change is the⚠️ suppression of the (infamous) NavBar.jsx ⚠️ file
The UI is now divided as follow:
ApplicationLayout
component that groups all the rest of the layoutTopMenu
component has the different quick-access tools available at the top (Tools, Assistant, etc. at the time of writing)SideMenu
component lists all the tools available to fact-checkersMainContent
component is where the content for the selected tool is displayedtools
file is introduced where all the tools are listed, where new tools can be added.constants
folder is introduced to manage the plugin's constants that should not be modified often.The current design choice is to get rid of ids and positions in array but use the tools' titles to identify them in redux instead. This allow to get rid of errors where the position in array or id could be wrong, which could introduce odd navigation behaviors, or even make the plugin crash totally.