Fix error handling in libafl_qemu_build #2036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect compiler Currently linker_interceptor.py uses 'cc' as the __LIBAFL_QEMU_BUILD_CC environment variable is never set
|
Looks good, thx! |
rmalmain
pushed a commit
that referenced
this pull request
Apr 11, 2024
* fix(libafl_qemu_build): assert command success * fix(libafl_qemu_build): make sure linker_interceptor.py picks up correct compiler Currently linker_interceptor.py uses 'cc' as the __LIBAFL_QEMU_BUILD_CC environment variable is never set * remove redudant arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix the entire problem, but fixes it for my use case.
It also sets the environment variables for the
makepart of the build as well to ensure that the correct compiler is picked up here:https://github.com/AFLplusplus/qemu-libafl-bridge/blob/ce4dbbc51390f86bad0a6e6cec52e5ed9cc34c85/linker_interceptor.py#L7-L9
Related to #2035