Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for ACCESS-RAM3 beta release #857

Draft
wants to merge 37 commits into
base: development
Choose a base branch
from

Conversation

heidinett
Copy link
Contributor

@heidinett heidinett commented Dec 10, 2024

Documentation for the beta release of ACCESS-RAM3

Fixes #841
Fixes #877

Copy link

github-actions bot commented Dec 10, 2024

PR Preview
🚀 Deployed preview to https://access-hive.org.au/pr-preview/pr-857
2025-02-07 08:54 AEDT

@heidinett heidinett marked this pull request as draft December 10, 2024 05:32
@heidinett heidinett changed the base branch from development to davide/access-ram-documentation December 11, 2024 00:42
docs/models/run-a-model/run-access-ram.md Show resolved Hide resolved
docs/models/run-a-model/run-access-ram.md Outdated Show resolved Hide resolved
docs/models/run-a-model/run-access-ram.md Outdated Show resolved Hide resolved
docs/models/run-a-model/run-access-ram.md Outdated Show resolved Hide resolved
docs/models/run-a-model/run-access-ram.md Outdated Show resolved Hide resolved
Copy link
Contributor

@flicj191 flicj191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to fix the hierarchy of the headings so that the navigation on he right can show the sub-headings

@engelca
Copy link

engelca commented Dec 11, 2024

The major comment relates to how persistent sessions work with the RAS/RNS.
In the RAS/RNS you currently have to ssh -Y directly into the persistent session to run the suite.
The suite can be edited thought via a non-persistent session.
To run from within a persistent session, I do the following:

  1. ls ~/.persistent-session/ to get the "persistent-session" name
  2. ssh -Y "persistent-session"
  3. module use /g/data/hr22/modulefiles
  4. module load cylc7
  5. cd roses
  6. cd "suite-directory"
  7. rose suite-run

In the Quickstart for both the RAS and RNS after taking the chekout/copy of the suite, the users needs to manually change into the suite directory prior to any further commands.

In the "Specify target persistent session" section. This doesn't work for me. I did do it but the rose suite-run command will crash. It only works from within the persistent-session. We need to either remove this section or edit the rose/cylc suite so the cylc-session file works.

In RAS/"Run the suite". again I can't run from a non-persistent session so I do the steps above first.

In RAS/"Monitor the suite runs". The text says two main ways but only the GUI way is listed. The second way is through the file system. The users have not been told of this option or where to look for the output files. The file locations are non-trivial, i.e. "output directory"/"user"/cylc-run/"suite-id"/log/job/"cycle-date"/"job-name"/"run-number; usually 01 unless repeated".

In RAS/"Edit the RAS configuration". There is a type "congiguration".

In RAS/"Change the region centre and name". The video is not showing (I did record one and upload it though ...)

In RNS/"RNS output files". The subdirectories (ics, lbcs, and um) are not being shown in a list. And another typo "scienc_choice".

In RNS/"Edit the RNS configuration". The "Rose GUI" link goes to the RAS specific example not to the "rose edit &" command above it.

@atteggiani atteggiani force-pushed the heidi/ram-doc-issue841 branch from 5533d4b to e4e1873 Compare February 5, 2025 01:29
@atteggiani atteggiani changed the base branch from davide/access-ram-documentation to development February 5, 2025 01:49
@atteggiani atteggiani force-pushed the heidi/ram-doc-issue841 branch from e4e1873 to c6134db Compare February 5, 2025 01:49
@atteggiani atteggiani force-pushed the heidi/ram-doc-issue841 branch from c6134db to 5196296 Compare February 5, 2025 01:51
@atteggiani atteggiani changed the title ACCESS-RAM3: Quick start guide (issue #841) Documentation for ACCESS-RAM3 Feb 5, 2025
@atteggiani atteggiani changed the title Documentation for ACCESS-RAM3 Documentation for ACCESS-RAM3 beta release Feb 5, 2025
@atteggiani atteggiani self-requested a review February 5, 2025 02:15
@atteggiani atteggiani force-pushed the heidi/ram-doc-issue841 branch from cc52c3a to 525eb0f Compare February 5, 2025 06:12
@atteggiani atteggiani force-pushed the heidi/ram-doc-issue841 branch from 17aeed9 to 0a0fe83 Compare February 5, 2025 07:06
Copy link
Contributor

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now the Hive Docs documentation for the beta release (and future 1.0 release) of the regional model.

I reintegrated a few portions (About, references, etc.) and adjusted a few minor things (please see my commits starting from 525eb0fe18722963483a596c38ae433813d02a36 for details) for consistency with the other "How to run" pages.

I added my review, listing both the comments in my previous version of the documentation (the ones that I had marked with a TODO within the code), and other additional comments (please refer to the related comments for details).
This will make it easier to add further reviews to this PR and commenting to the specific portions/comments with ideas and suggestions.

Comment on lines +3 to +5
TODO
{: style="color:red"}
<!-- Create the model overview page for ACCESS-RAM. Refer to the ACCESS-ESM1.5 one for an example. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TODO
{: style="color:red"}
<!-- Create the model overview page for ACCESS-RAM. Refer to the ACCESS-ESM1.5 one for an example. -->

Add the model overview page for ACCESS-RAM.
More details in #877's first task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engelca Could you please comment on how our ACCESS-NRI RAM3 configuation differs from the UKMO RNS.
Perhaps users need to know that there is a different config option using an existing executable instead of building the model, and that python scripts exist.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engelca Could you please address this comment?
In addition to what heidi mentioned, I think the overview page should have content about any information that we would like to provide about the configuration, so that we can link to this overview page also within the "How to run page", without having redundant information in the latter.

<!-- ACCESS-RAM -->
<a href="/models/configurations/access-ram/" class="horizontal-card">
<div class="card-image-container">
<img src="/assets/model-config-logos/configurations-without-titles/access-om.png" class="white-background img-contain"></img>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="/assets/model-config-logos/configurations-without-titles/access-om.png" class="white-background img-contain"></img>
<img src="/assets/model-config-logos/configurations-without-titles/access-ram.png" class="white-background img-contain"></img>

The access-ram.png currently doesn't exist. It should be created and added to the repo.
Maybe Natalia has updates on the configuration image for the regional model?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ACCESS-NRI/webops will take care of this.

<div class="card-text-container">
<span class="bold" >ACCESS-RAM</span>
<span>
ACCESS-RAM -- add text here. Also add correct image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ACCESS-RAM -- add text here. Also add correct image.
ACCESS-RAM is ............

Add a short description of what ACCESS-RAM is, similarly to what it's done for the other models above in the page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was included separately in the RAS and RNS descriptions in my branch. Maybe they can be combined here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link the specific content you are referring to or, maybe better, write a comment below with the "combined" content you are suggesting?

<!-- Run ACCESS-RAM -->
<a href="/models/run-a-model/run-access-ram" class="vertical-card aspect-ratio1to1">
<div class="card-image-container">
<img class="img-contain with-padding white-background" src="/assets/model-config-logos/globe_visualisation/access_om_globe_visualisation.png" alt="ACCESS-RAM">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img class="img-contain with-padding white-background" src="/assets/model-config-logos/globe_visualisation/access_om_globe_visualisation.png" alt="ACCESS-RAM">
<img class="img-contain with-padding white-background" src="/assets/model-config-logos/globe_visualisation/access_ram_globe_visualisation.png" alt="ACCESS-RAM">

The access_ram_globe_visualisation.png currently doesn't exist. It should be created and added to the repo.
Do we have an image similar to the other in the page that can be used for ACCESS-RAM?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ACCESS-NRI/webops will take care of this.

Comment on lines 10 to 13
<!--
TODO
{: style="color:red"}
<!-- Can we put a configuration here taken from MOSRS instead of GitHub? SVN? -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--
TODO
{: style="color:red"}
<!-- Can we put a configuration here taken from MOSRS instead of GitHub? SVN? -->

Can we place the link of a configuration taken from MOSRS?
Maybe they can two separate ones, one for RAS and one for RNS.
What about https://code.metoffice.gov.uk/trac/roses-u/browser/d/g/7/6/7/trunk and https://code.metoffice.gov.uk/trac/roses-u/browser/d/g/7/6/8/trunk?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They would need to be two separate links to MOSRS. The ones listed would be the right ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm going to add those links. Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +649 to +657
<!--
The RNS is ...
-->
The `suite-ID` of the RNS is `{{ rns_id }}`.

<!--
TODO
{: style="color:red"}
<!-- Add short description of what the RAS does -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--
The RNS is ...
-->
The `suite-ID` of the RNS is `{{ rns_id }}`.
<!--
TODO
{: style="color:red"}
<!-- Add short description of what the RAS does -->
The RNS is ...
The `suite-ID` of the RNS is `{{ rns_id }}`.

Would be good to add a short description (2-3 lines) of what the RNS does.
Also include the RNS suite-ID.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those variables get filled in by the markup when it is run.

The description for the RNS was included in my original branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chermelle Can you please add a short suitable description in a comment below? Thank you.

Comment on lines +673 to +690
The RNS output data can be found in the `/scratch/$PROJECT/$USER/cycl-run/<suite-ID>/share/cycle` directory, grouped for each [cycle](#change-run-length-and-cycling-frequency).<br>
Within the cycle directory, outputs are divided into multiple nested subdirectories in the format `<nested_region>/<science_choice>/<nest_name>`, with [nested_region](), [science_choice]() and [nest_name]() referring to the respective configurable options in the [RAS](#edit-the-ras-configuration).

<!--
TODO
{: style="color:red"}
<!-- Use the same names for `nested_region` `science_choice` and `nest_name` as the one used above for the RAS and make sure all of the are referenced in the RAS and there are clear instructions on how to modify them. There is no reference for how to change the `science_choice`. If it cannot be changed, I would call it in a different way. Add links -->

Each of the `<nest_name>` directory has the following subdirectories:

- `ics` &rarr; initial conditions
- `lbcs` &rarr; lateral boundary conditions
- `um` &rarr; model output data

<!--
TODO
{: style="color:red"}
<!-- Use the same names for `nested_region` `science_choice` and `nest_name` as the one used above for the RAS and make sure all of the are referenced in the RAS and there are clear instructions on how to modify them. Add links -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The RNS output data can be found in the `/scratch/$PROJECT/$USER/cycl-run/<suite-ID>/share/cycle` directory, grouped for each [cycle](#change-run-length-and-cycling-frequency).<br>
Within the cycle directory, outputs are divided into multiple nested subdirectories in the format `<nested_region>/<science_choice>/<nest_name>`, with [nested_region](), [science_choice]() and [nest_name]() referring to the respective configurable options in the [RAS](#edit-the-ras-configuration).
<!--
TODO
{: style="color:red"}
<!-- Use the same names for `nested_region` `science_choice` and `nest_name` as the one used above for the RAS and make sure all of the are referenced in the RAS and there are clear instructions on how to modify them. There is no reference for how to change the `science_choice`. If it cannot be changed, I would call it in a different way. Add links -->
Each of the `<nest_name>` directory has the following subdirectories:
- `ics` &rarr; initial conditions
- `lbcs` &rarr; lateral boundary conditions
- `um` &rarr; model output data
<!--
TODO
{: style="color:red"}
<!-- Use the same names for `nested_region` `science_choice` and `nest_name` as the one used above for the RAS and make sure all of the are referenced in the RAS and there are clear instructions on how to modify them. Add links -->
The RNS output data can be found in the `/scratch/$PROJECT/$USER/cycl-run/<suite-ID>/share/cycle` directory, grouped for each [cycle](#change-run-length-and-cycling-frequency).<br>
Within the cycle directory, outputs are divided into multiple nested subdirectories in the format `<nested_region>/<science_choice>/<nest_name>`, with [nested_region](<LINK>), [science_choice](<LINK>) and [nest_name](<LINK>) referring to the respective configurable options in the [RAS](#edit-the-ras-configuration).
Each of the `<nest_name>` directory has the following subdirectories:
- `ics` &rarr; initial conditions
- `lbcs` &rarr; lateral boundary conditions
- `um` &rarr; model output data

Use the same names for <nested_region> <science_choice> and <nest_name> as the one used above for the RAS and make sure all of them are referenced in the RAS and there are clear instructions on how to modify them. Make sure <LINK> is substituted with the proper link to the related portion/paragraph of the RAS.

There is no reference to how to change the science_choice, it would be good to add instructions. If it cannot be changed, I would maybe call it in a different way.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the RNS puts data into directories named with a convention naming the science choice.

Changing the science choice has implications beyond a "introductory simple guide". Perhaps we should note that it is out of scope for the "run-a-model" guide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you suggest, I would then write a very short line about what science_choice is (based on what you wrote in the comment above), and not mention it within the configuration options that users can change.
Can you please provide, in a comment below, a short paragraph we can use in the documentation to describe the science_choice parameter (and maybe the fact that its change is beyond the scope of this guide)? Thank you.

Comment on lines +708 to +714
#### Change where the output from run is stored project
To change where the output from the model run is stored, edit the _NCI_STORAGE_ field in _suite conf &rarr; Nesting Suite &rarr; General run options _, and click the _Save_ button ![Save button](/assets/run_access_cm/save_button.png){: style="height:1em"}.

<!--
TODO
{: style="color:red"}
<!-- I couldn't restructure this title/text because from them I am not really understanding what `NCI_STORAGE` is. From its default value in the rose-suite.conf (scratch/$PROJECT) and how it's used inside the suite, it seems to be a project folder added to the `storage` option for the PBS jobs submission of many tasks. Therefore is not necessarily related to model outputs (is also related to model input), but to filesystem mounts that the model need to be able to access. Why is the text mentioning changing where the output is stored? -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Change where the output from run is stored project
To change where the output from the model run is stored, edit the _NCI_STORAGE_ field in _suite conf &rarr; Nesting Suite &rarr; General run options _, and click the _Save_ button ![Save button](/assets/run_access_cm/save_button.png){: style="height:1em"}.
<!--
TODO
{: style="color:red"}
<!-- I couldn't restructure this title/text because from them I am not really understanding what `NCI_STORAGE` is. From its default value in the rose-suite.conf (scratch/$PROJECT) and how it's used inside the suite, it seems to be a project folder added to the `storage` option for the PBS jobs submission of many tasks. Therefore is not necessarily related to model outputs (is also related to model input), but to filesystem mounts that the model need to be able to access. Why is the text mentioning changing where the output is stored? -->
#### Change where the output from run is stored project
To change where the output from the model run is stored, edit the _NCI_STORAGE_ field in _suite conf &rarr; Nesting Suite &rarr; General run options _, and click the _Save_ button ![Save button](/assets/run_access_cm/save_button.png){: style="height:1em"}.

I am not sure what NCI_STORAGE is. From its default value in the rose-suite.conf (scratch/$PROJECT) and how it's used inside the suite, it seems to be a project folder added to the storage option for the PBS jobs submission of multiple tasks. Therefore, is not necessarily related to model outputs but also related to model input.
I would say in general is related to filesystem mounts that the model need to be able to access.
Why is the text mentioning changing where the output is stored?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NCI_STORAGE impacts where the user wants the output of their runs to be stored.
It is mentioned to given an example of changing where the output from the run is stored.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the RNS (u-dg768) I can only see NCI_STORAGE being added to the pbs storage option for different tasks, but I cannot see any part that link it to the experiment output.
I can see NCI_STORAGE_TOP_DIR used to provide an env variable to the ARCHIVE task (which might define where the output is being stored).

Can you please point me to a portion of the RNS suite where there is link between the NCI_STORAGE variable and the output of the run?
Thank you

Comment on lines +724 to +729
To modify these parameters, navigate to _suite conf &rarr; Nesting Suite &rarr; Cycling options_, edit the `INITIAL_CYCLE_POINT`, `FINAL_CYCLE_POINT` and the `CYCLE_INT_HR` fields (using [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations) format) and click the _Save_ button ![Save button](/assets/run_access_cm/save_button.png){: style="height:1em"}.

<!--
TODO
{: style="color:red"}
<!-- Are there any other options more specific to the RNS that users may want to change here? -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To modify these parameters, navigate to _suite conf &rarr; Nesting Suite &rarr; Cycling options_, edit the `INITIAL_CYCLE_POINT`, `FINAL_CYCLE_POINT` and the `CYCLE_INT_HR` fields (using [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations) format) and click the _Save_ button ![Save button](/assets/run_access_cm/save_button.png){: style="height:1em"}.
<!--
TODO
{: style="color:red"}
<!-- Are there any other options more specific to the RNS that users may want to change here? -->
To modify these parameters, navigate to _suite conf &rarr; Nesting Suite &rarr; Cycling options_, edit the `INITIAL_CYCLE_POINT`, `FINAL_CYCLE_POINT` and the `CYCLE_INT_HR` fields (using [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations) format) and click the _Save_ button ![Save button](/assets/run_access_cm/save_button.png){: style="height:1em"}.

Are there any further options specific to the RNS, that users may want to change, that could be added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chermelle
This is related to another comment above, about the configuration options that we want to include in the instructions.
I think whatever configuration options we decide to detail in the instructions, we might want to add the options specific to the RNS here.

Comment on lines +731 to +738
<!--
## Get Help
If you have questions or need help regarding {{ model }}, consider creating a topic in the [Earth System Model category of the ACCESS-Hive Forum](https://forum.access-hive.org.au/c/esm/earth-system-model/72).<br>
For assistance on how to request help from ACCESS-NRI, follow the [guidelines on how to get help](/about/user_support/#still-need-help).

TODO
{: style="color:red"}
<!-- Check and change link details if needed -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--
## Get Help
If you have questions or need help regarding {{ model }}, consider creating a topic in the [Earth System Model category of the ACCESS-Hive Forum](https://forum.access-hive.org.au/c/esm/earth-system-model/72).<br>
For assistance on how to request help from ACCESS-NRI, follow the [guidelines on how to get help](/about/user_support/#still-need-help).
TODO
{: style="color:red"}
<!-- Check and change link details if needed -->
## Get Help
If you have questions or need help regarding {{ model }}, consider creating a topic in the ........ category of the ACCESS-Hive Forum](<LINK>).<br>
For assistance on how to request help from ACCESS-NRI, follow the [guidelines on how to get help](/about/user_support/#still-need-help).

Add the right forum category with the <LINK>.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ACCESS-NRI/webops can take care of this, once there is a Forum post of the release.

…isation' to 'model-config-logos/model_visualisation' and changed 'globe_visualisations' part of assets name to 'model_visualisations'

- Deleted unused asset folder 'assets/globe_visualisations'
- Updated image for 'Run ACCESS-RAM' card
@atteggiani atteggiani requested review from flicj191 and removed request for flicj191 February 6, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants