-
Notifications
You must be signed in to change notification settings - Fork 0
Extend historical volcanic forcing to 2300 #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
atteggiani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @penguian.
This looks good.
I left two comments, but I don't think they are extremely important, so feel free to merge without addressing them.
|
Is there an example output file somewhere? |
bdf6aba to
420f2b5
Compare
|
@MartinDix See /g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/historical/atmosphere/forcing/resolution_independent/2025.11.25/volcts_cmip7.dat |
|
Good catch. See |
|
Pinatubo now looks spot on, but there are some other eruptions where the peak in your file is different to what I get from the data. Zooming in on Fig 5 of https://docs.google.com/document/d/1blX5kv0We1BteqWzMKs0OuhazAcAonay I estimate 0.081 for the 1912 peak, so agreeing with my value. This eruption was at high N latitude so perhaps something off with the latitude weights? The band order is also reversed in your file. The code is awkward but https://github.com/ACCESS-NRI/UM7/blob/f69fbab14ab57dcfa26117a9ffd9ccab899d293f/umbase_hg3/src/control/top_level/glue_rad-rad_ctl2.F90#L2325-L2342 shows that the first band is 30N-90N. |
|
As for the latitude bands, I did check the Fortran code, but didn't notice that the first index used in |
|
See the last commit and see The weighting at CMIP7/esm1p6/atmosphere/volcanic/cmip7_volcanic.py#L31 uses |



Closes issue #92