Skip to content

Conversation

@penguian
Copy link
Collaborator

@penguian penguian commented Oct 7, 2025

Closes issue #92

@penguian penguian self-assigned this Oct 7, 2025
@penguian penguian linked an issue Oct 7, 2025 that may be closed by this pull request
@penguian penguian marked this pull request as draft October 7, 2025 23:40
@penguian penguian marked this pull request as ready for review October 8, 2025 05:21
@penguian penguian requested a review from MartinDix October 8, 2025 05:21
atteggiani
atteggiani previously approved these changes Oct 22, 2025
Copy link
Collaborator

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @penguian.

This looks good.
I left two comments, but I don't think they are extremely important, so feel free to merge without addressing them.

@penguian penguian requested a review from atteggiani October 27, 2025 06:22
@penguian penguian marked this pull request as draft October 28, 2025 00:28
@penguian penguian marked this pull request as ready for review October 28, 2025 00:55
@penguian penguian marked this pull request as draft November 16, 2025 23:15
@penguian penguian marked this pull request as ready for review November 16, 2025 23:16
@MartinDix
Copy link
Collaborator

Is there an example output file somewhere?

@penguian penguian force-pushed the 92-extend-historical-volcanic-forcing-to-2300 branch from bdf6aba to 420f2b5 Compare November 25, 2025 04:16
@penguian
Copy link
Collaborator Author

@MartinDix See /g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/historical/atmosphere/forcing/resolution_independent/2025.11.25/volcts_cmip7.dat

@MartinDix
Copy link
Collaborator

Data in this file seems to have a one month time offset. E.g. Pinatubo erupted in June 1991 and the input4MIPS and ESM1.5 CMIP6 file show AOD increasing in July but it's not until August in your file

pinatubo
/g/data/vk83/experiments/inputs/access-esm1p5/modern/historical/atmosphere/forcing/resolution_independent/2021.06.22/volcts_cmip6.dat
1991     4    97    68    75  103
1991     5    93    70    76  107
1991     6   165   109    78  116
1991     7   304   465   400  161
1991     8   422  1415   964  379
/g/data/tm70/pcl851/CMIP7/esm16_ancil/modern/historical/atmosphere/forcing/resolution_independent/2025.11.25/volcts_cmip7.dat
1991    4   79.1   49.1   44.5   65.0
1991    5   77.3   48.7   44.0   65.7
1991    6   81.6   49.2   44.7   60.8
1991    7   86.4   50.7   45.0   75.0
1991    8  108.2  268.2  463.8  258.2
1991    9  294.4  722.4  843.4  322.3

@penguian penguian marked this pull request as draft November 27, 2025 04:27
@penguian
Copy link
Collaborator Author

Good catch. See /home/851/pcl851/gdata/CMIP7/esm1p6_ancil/2025.11.27/modern/historical/atmosphere/forcing/resolution_independent/2025.11.27/volcts_cmip7.dat for the corrected file output.

@penguian penguian marked this pull request as ready for review November 27, 2025 10:49
@MartinDix
Copy link
Collaborator

Pinatubo now looks spot on, but there are some other eruptions where the peak in your file is different to what I get from the data.
volc_aod

Zooming in on Fig 5 of https://docs.google.com/document/d/1blX5kv0We1BteqWzMKs0OuhazAcAonay I estimate 0.081 for the 1912 peak, so agreeing with my value. This eruption was at high N latitude so perhaps something off with the latitude weights?
aod_1912

The band order is also reversed in your file. The code is awkward but https://github.com/ACCESS-NRI/UM7/blob/f69fbab14ab57dcfa26117a9ffd9ccab899d293f/umbase_hg3/src/control/top_level/glue_rad-rad_ctl2.F90#L2325-L2342 shows that the first band is 30N-90N.

/g/data/tm70/pcl851/CMIP7/esm1p6_ancil/2025.11.27/modern/historical/atmosphere/forcing/resolution_independent/2025.11.27/volcts_cmip7.dat
1912    5   44.1   28.9   26.3   46.6
1912    6   46.7   30.8   71.1  345.7
1912    7   53.9   62.8  207.4 1214.9
/g/data/vk83/experiments/inputs/access-esm1p5/modern/historical/atmosphere/forcing/resolution_independent/2021.06.22/volcts_cmip6.dat
1912     5   142    50    51  64
1912     6   592    68    52  68
1912     7  1387   127    54  72

See https://github.com/ACCESS-NRI/CMIP7-Input/blob/92-historical-volcanic-check/examples/esm1p6/historical/atmosphere/volcanic/volcanic_aod.ipynb

@penguian
Copy link
Collaborator Author

penguian commented Dec 1, 2025

As for the latitude bands, I did check the Fortran code, but didn't notice that the first index used in VOLCTS was decreasing from 4 down to 1. I will rectify this.

@penguian penguian marked this pull request as draft December 1, 2025 01:43
@penguian
Copy link
Collaborator Author

penguian commented Dec 1, 2025

See the last commit and see gadi:/g/data/tm70/pcl851/CMIP7/esm1p6_ancil/2025.12.01/modern/historical/atmosphere/forcing/resolution_independent/2025.12.01/volcts_cmip7.dat for the updated output. I used cell.point in the comparison as well as reversing the order of the latitude bands.

The weighting at CMIP7/esm1p6/atmosphere/volcanic/cmip7_volcanic.py#L31 uses iris.analysis.cartography.cosine_latitude_weights(cube) after constraining the cube to a latitude band.

@penguian penguian marked this pull request as ready for review December 1, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend historical volcanic forcing to 2300

4 participants