fix(get): accurate error when a glob excludes all tracked files under a path#263
Open
CGMossa wants to merge 1 commit into
Open
fix(get): accurate error when a glob excludes all tracked files under a path#263CGMossa wants to merge 1 commit into
CGMossa wants to merge 1 commit into
Conversation
5 tasks
… a path resolve_paths_for_get reported "not tracked by DVS" for every explicit path that matched no tracked file, even when the path has tracked files and the provided glob merely excluded all of them. Re-check such paths without the glob and report them under a distinct message naming the glob pattern. Mixed failures list each path under the correct heading. Both cases still refuse the whole batch. Spec: state that explicit file paths bypass the glob in add, get, and status, and document the glob-excluded error variant for get. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CGMossa
force-pushed
the
fix/get-glob-error-message
branch
from
July 16, 2026 08:32
fe809d5 to
889589c
Compare
Contributor
Author
|
This is related to #277. So we have to think about where this makes the most sense to add ignored paths. |
Contributor
Author
|
TODO: replace this line with your own framing, in your own voice.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: replace this line with your own framing, in your own voice.
AI-written details
Summary
resolve_paths_for_getreported "The following paths are not tracked by DVS" for every explicit path that matched no tracked file, even when the path has tracked files and the provided glob merely excluded all of them (e.g.dvs get data/ --glob '*.parquet'wheredata/holds only tracked CSVs).add,get, andstatus. The get section documents the glob-excluded error variant.resolve_paths_for_getindvs/src/globbing.rs.PathFilter::matches,resolve_paths_for_add,get.rs, andadd.rsare untouched.Test plan
cargo test -p dvs(81 passed, includes three new tests: glob excludes everything, untracked path with glob, mixed failure with both headings)cargo clippy -p dvs --all-targets(no warnings)cargo fmt --checkNotes
PathFilter::matchesis deliberately unchanged (covered byget_explicit_file_ignores_glob) and is now stated in the spec for all three commands.Drafted by Claude (claude-fable-5). Reviewed by the author.