Homework 2 #16
Open
Homework 2 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinbinhuang
reviewed
Aug 12, 2019
| from alpha_vantage.timeseries import TimeSeries | ||
| ts = TimeSeries(key='YADS9AQEC5BOFNJK',output_format='pandas') | ||
| # Get json object with the intraday data and another with the call's metadata | ||
| def Get_stocks(): |
There was a problem hiding this comment.
Python is case-sensitive: the function name Get_stocks() should be the same as what you pass in t1. Suggetsed to have them both called get_stocks()
xinbinhuang
requested changes
Aug 12, 2019
| from alpha_vantage.timeseries import TimeSeries | ||
| ts = TimeSeries(key='YADS9AQEC5BOFNJK',output_format='pandas') | ||
| # Get json object with the intraday data and another with the call's metadata | ||
| def Get_stocks(): |
There was a problem hiding this comment.
When you pass provide_context=True in the PythonOperator. Make sure to have your python callables to accept key-word arugments (i.e. def get_stocks(**context))
| @@ -0,0 +1 @@ | |||
| pandas alpha_vantage | |||
There was a problem hiding this comment.
Need to put each dependency in a new line.
| webserver: | ||
| image: puckel/docker-airflow:1.8.1 | ||
| restart: always | ||
| command: |
There was a problem hiding this comment.
Do not specify multiple command in the docker-compose file.
- The first command will be overwritten by the later one
- It's not clear for other developers
To have multiple bash commands, do something like this bash -c "<long string of commands>" docker/compose#2033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.