Add hw2 *and* hw4 😎 #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 21, 2019 20:37
added 2 commits
July 28, 2019 22:38
|
@xinbinhuang can you please check hw2 in this PR? |
xinbinhuang
requested changes
Aug 12, 2019
| """ | ||
| json_data = requests.get(request).json() | ||
|
|
||
| with open('../data/data.json', 'w') as outfile: |
There was a problem hiding this comment.
Be careful of relative file paths.
The DAG failed because the current path is the airflow root directory rather than the DAG home.
There was a problem hiding this comment.
👍 Changed it to data/raw/data.json - is this correct?
|
|
||
| task1 = BashOperator( | ||
| task_id="blastoff", | ||
| bash_command="echo '🚀 blastoff'", |
There was a problem hiding this comment.
The 🚀 causes an error for airflow to load the dag
- Change relative path - Remove rocketship emoji
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.