Skip to content

Generate constant for types without arguments #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Almighty-Alpaca wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Generate constant for types without arguments #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271d41d
Generate constant for types without arguments
Almighty-Alpaca Dec 8, 2021
fd75394
Fix incorrect code generation
Almighty-Alpaca Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/bin/example.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'sealed/nullsafe/data/generic/result_single_1.dart';
import 'sealed/nullsafe/data/simple/weather.dart';

void main() {
final a = Weather.sunny();
final a = Weather.sunny;
final b = Weather.rainy(rain: 12);
final c = Weather.windy(velocity: 1.5, angle: null);

Expand Down
8 changes: 4 additions & 4 deletions example/bin/sealed/nullsafe/data/simple/meta.sealed.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions example/bin/sealed/nullsafe/data/simple/weather.sealed.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions example/bin/sealed/nullsafe/distinct/simple/weather.sealed.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions example/bin/sealed/nullsafe/identity/simple/weather.sealed.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 14 additions & 6 deletions sealed_writer/lib/src/writer/top/top_builder_writer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,23 @@ class TopBuilderWriter extends BaseUtilsWriter {
';',
].joinParts();

/// ex. factory Weather.sunny() = WeatherSunny;
/// ex. static const Weather sunny = WeatherSunny();
///
/// ex. factory Result.success(...) = ResultSuccess<T>;
String topFactoryBuilder(ManifestItem item) => [
'const factory $top.${subLower(item)}',
topBuilderDecArgs(item),
' = ',
subCall(item),
';',
if (item.fields.isNotEmpty) ...<String>[
'const factory $top.${subLower(item)}',
topBuilderDecArgs(item),
' = ',
subCall(item),
';',
],
if (item.fields.isEmpty) ...<String>[
'static const $top ${subLower(item)}',
' = ',
subCall(item),
'();',
]
].joinParts();

/// top builder methods
Expand Down