Refactor test_export_html to work with modules #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holybiber
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Hi @JoshKowi thanks, that looks clean and good!
I noticed minor things, can you fix them?
- Can you restore the introductory documentation? (first 12 lines, looks like you accidentally did two changes there)
- Please delete the two lines
self.configas it's not used - flake8 has one complaint
|
Changed as requested. 👍 |
|
About flake8: I thought that if we are going to use black anyway, it might not be important to care about flake8 - should I install black and let it run, or are we going to do that on github? |
|
Great, thanks. Yeah that wasn't any real issue, it just looks better to have all the CI checks return green on commits and PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the test_export_html to work with the New refactored modularization