-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/113/implement proper module registration #119
Merged
holybiber
merged 54 commits into
4training:main
from
GabrielSousa02:refactor/113/implement-proper-module-registration
Nov 22, 2024
Merged
Refactor/113/implement proper module registration #119
holybiber
merged 54 commits into
4training:main
from
GabrielSousa02:refactor/113/implement-proper-module-registration
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Follow PEP8 standards
- create the modules' field - add to docstring - add logic to call specified modules
- test_consistency_checks.py - test_write_lists.py - test_write_report.py - test_write_sidebar_messages.py - test_write_summary.py
…match parent class
…for `LanguagePostProcessor`
- Change constructors for `LanguagePostProcessor`s - Change the `Resourcesbot` constructor - Update the `AVAILABLE_MODULES` const - Update iteration of the post-processors, instantiating the class and calling `run()`
TODO: Fix one failing test
Fixed the one failing test...
Finally done!
Feedback for next time:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#113 Refactor CLI to include option for LanguagePostProcessors, instead of keeping the hardcoded options only.
Why?
This will facilitate for the user to select what should be executed by the script.
How?
Refactoring the
ABC
class by adding a constructor and then specializing the constructor per each class. Updating the CLIargparser
to include the modules as options, creating default value for the modules (all
) and then revamping the iteration over all selected modules to use one single initializer, since now we have the same constructor signatures, and then calling therun()
method.Testing?
Only two tests were failing, need to review them under,
test_resourcesbot.py
:test_rewrite_options
test_run_with_cache
Screenshots (optional)
Anything Else?