Skip to content

Conversation

@arthuro555
Copy link
Contributor

@arthuro555 arthuro555 commented Apr 1, 2025

Closes #6530

This update is long due, this update shouldn't require deep changes to GDevelop, and only needed minor updates to a few dependencies.
I picked v32 instead of latest as there are changes to native modules in v33 that might have more unpredictable impacts on desktop builds.

Tested the IDE, tested making and running a manual build of a test project with the steamworks extension. Everything seems to work.

@arthuro555 arthuro555 requested a review from 4ian as a code owner April 1, 2025 10:55
@4ian
Copy link
Owner

4ian commented Apr 3, 2025

Thanks for doing this! I'll launch an experimental build to see if we can test built versions on multiple systems.

@arthuro555
Copy link
Contributor Author

Hmm.... The build errors are because the ubuntu version of the CI is too old and doesn't bundle gcc with c++ 20 support :/
I had not updated to the latest version of electron precisely to avoid these troubles, but I guess electron-builder already adopted the requirement too 😓

That means that the one-click packaging service probably also will need to be updated and tested for c++ 20 support before shipping this update!

@arthuro555
Copy link
Contributor Author

(We probably should wait before updating electron more still though, as there are other breaking changes with worrying implications in v33)

@4ian 4ian force-pushed the master branch 3 times, most recently from 8a32fc5 to 846afd9 Compare August 30, 2025 12:16
@arthuro555
Copy link
Contributor Author

oh my god what is UP with these CI

@4ian
Copy link
Owner

4ian commented Oct 21, 2025

We can ignore semaphore and Travis. I'll launch experimental builds for this branch

@4ian
Copy link
Owner

4ian commented Oct 21, 2025

Started 👍 Let's see

@arthuro555
Copy link
Contributor Author

I added in a little extra fix - if you used the "Hide a window" electron action, requestAnimationFrame would stop firing, making it impossible to get the window to come back up - I set an option on previews and build BrowserWindows to disable this behavior.

@arthuro555
Copy link
Contributor Author

Hmm, it looks like electron-builder slightly changed the code signing configuration

@4ian
Copy link
Owner

4ian commented Oct 25, 2025

Just tested this on Windows and macOS, so far I don't see any issue! :)
A web export seems to work, no issues found when playing a few projects, Piskel seem to work fine.

You said you could run a manual build of a game with Steamworks, no issue there too?
I believe that's the main "native module" that we rely on. Anything else on your mind that would be worth checking?

@arthuro555
Copy link
Contributor Author

arthuro555 commented Oct 26, 2025

image

hm, i tired doing a one click build with the nightly build and it looks like it didnt work...
the build service will need to be adapted before merging

@4ian
Copy link
Owner

4ian commented Oct 26, 2025

Ah right obviously the electron version of games is also updated. Totally overlooked this. I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Electron 18.x.y has reached end-of-support

2 participants