-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update electron to v32 #7525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update electron to v32 #7525
Conversation
|
Thanks for doing this! I'll launch an experimental build to see if we can test built versions on multiple systems. |
|
Hmm.... The build errors are because the ubuntu version of the CI is too old and doesn't bundle gcc with c++ 20 support :/ That means that the one-click packaging service probably also will need to be updated and tested for c++ 20 support before shipping this update! |
|
(We probably should wait before updating electron more still though, as there are other breaking changes with worrying implications in v33) |
8a32fc5 to
846afd9
Compare
4a22fa6 to
8a25123
Compare
|
oh my god what is UP with these CI |
|
We can ignore semaphore and Travis. I'll launch experimental builds for this branch |
|
Started 👍 Let's see |
|
I added in a little extra fix - if you used the "Hide a window" electron action, requestAnimationFrame would stop firing, making it impossible to get the window to come back up - I set an option on previews and build |
|
Hmm, it looks like electron-builder slightly changed the code signing configuration |
|
Just tested this on Windows and macOS, so far I don't see any issue! :) You said you could run a manual build of a game with Steamworks, no issue there too? |
|
Ah right obviously the electron version of games is also updated. Totally overlooked this. I'll take a look! |

Closes #6530
This update is long due, this update shouldn't require deep changes to GDevelop, and only needed minor updates to a few dependencies.
I picked v32 instead of latest as there are changes to native modules in v33 that might have more unpredictable impacts on desktop builds.
Tested the IDE, tested making and running a manual build of a test project with the steamworks extension. Everything seems to work.