Skip to content

27 login page is very verbose #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2024
Merged

27 login page is very verbose #32

merged 4 commits into from
Mar 13, 2024

Conversation

liamdewitt
Copy link
Contributor

No description provided.

Connor-Skudlarek
Connor-Skudlarek approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@Connor-Skudlarek Connor-Skudlarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the .tsx, might have been a carry over from when I was messing with authentication (I usually use typescript for that, so would make sense).

@Connor-Skudlarek Connor-Skudlarek merged commit c8590d7 into main Mar 13, 2024
@Connor-Skudlarek Connor-Skudlarek deleted the 27-login-page-is-very-verbose branch March 13, 2024 19:56
@Connor-Skudlarek Connor-Skudlarek restored the 27-login-page-is-very-verbose branch March 14, 2024 01:30
Connor-Skudlarek added a commit that referenced this pull request Mar 14, 2024
@Connor-Skudlarek
Fixed breaking changes from issue #27 and add AlternativeLogins to page
aa03a13 
A breaking change was added in PR #32 addressing issue #27 (verbose login page file).
#npm run build
#npm run start
Both work.
@Connor-Skudlarek Connor-Skudlarek deleted the 27-login-page-is-very-verbose branch June 9, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor-Skudlarek Connor-Skudlarek Connor-Skudlarek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdewitt @Connor-Skudlarek