add social logins #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| export default function LoginForm({ handleSubmit }) { | ||
| return ( | ||
| <div className="mx-5 mt-5 flex flex-col"> |
There was a problem hiding this comment.
This missing from original form component. Added.
| . | ||
| </div> | ||
| </form>; | ||
| ); |
There was a problem hiding this comment.
The rest of this green is simply "Prettier" running. Nothing crazy.
| @@ -34,11 +36,10 @@ export default function LoginPage() { | |||
|
|
|||
| return ( | |||
| <main className="flex"> | |||
| <section className="flex flex-col py-12 px-16"> | |||
There was a problem hiding this comment.
The flex-col is stacking all of the elements. Not the intended behavior.
| <div className="mt-5 mx-5"></div> | ||
| <LoginForm /> | ||
| <section className="flex flex-row px-16 py-12"> | ||
| <LoginForm handleSubmit={handleSubmit} /> |
There was a problem hiding this comment.
This is part of fixing the breaking change.
| @@ -25,7 +25,8 @@ npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
|
|
|||
| # local env files | |||
| # env files | |||
| .env | |||
There was a problem hiding this comment.
Just getting the .env file out of the repo. Doesn't have any actual security credentials—so, just a proactive step to prevent security leak. ;)
Connor-Skudlarek
approved these changes
Mar 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The styling for this component is meant to work with the styling that includes the 14-login-page-login-separator.