-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [Automatic] Constraints upgrades: numpy
, partsegcore-compiled-backend
, tifffile
#1253
Conversation
Reviewer's Guide by SourceryThis pull request updates the constraint files for various Python versions and configurations, upgrading packages such as No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThis pull request updates dependency versions across multiple requirements files for Python 3.9, 3.10, 3.11, and 3.12 environments. Each file now references newer versions for packages such as Changes
Possibly related PRs
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Czaki - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider grouping the constraint changes by python version to improve readability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
requirements/constraints_py3.10_pydantic_1.txt (1)
182-182
: Ensurenumpy
is updated to 2.2.4
Please double-check that the numpy version in this constraints file is indeed 2.2.4 (as stated by the PR objectives) to maintain consistency with non‑pydantic constraints.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
requirements/constraints_py3.10.txt
(6 hunks)requirements/constraints_py3.10_pydantic_1.txt
(6 hunks)requirements/constraints_py3.11.txt
(6 hunks)requirements/constraints_py3.11_pydantic_1.txt
(6 hunks)requirements/constraints_py3.12.txt
(6 hunks)requirements/constraints_py3.12_docs.txt
(5 hunks)requirements/constraints_py3.12_pydantic_1.txt
(6 hunks)requirements/constraints_py3.9.txt
(4 hunks)requirements/constraints_py3.9_pydantic_1.txt
(4 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (28)
- GitHub Check: 4DNucleome.PartSeg (Tests_other test windows)
- GitHub Check: 4DNucleome.PartSeg (Tests_other test macos)
- GitHub Check: 4DNucleome.PartSeg (Tests_linux test_linux)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller windows)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos_arm)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller_linux)
- GitHub Check: 4DNucleome.PartSeg (Builds pyinstaller macos)
- GitHub Check: 4DNucleome.PartSeg (Builds sdist)
- GitHub Check: Base py3.12 / ubuntu-22.04 py 3.12 latest PyQt6
- GitHub Check: Base py3.10 / ubuntu-20.04 py 3.10 latest PySide2
- GitHub Check: Base py3.12 / macos-14 py 3.12 latest PyQt6
- GitHub Check: Base py3.10 / ubuntu-22.04 py 3.10 latest PyQt5 _pydantic_1
- GitHub Check: Base py3.11 / macos-13 py 3.11 latest PyQt5
- GitHub Check: Base py3.10 / ubuntu-24.04 py 3.10 latest PyQt5
- GitHub Check: Base py3.10 / ubuntu-24.04 py 3.10 latest PySide6
- GitHub Check: Base py3.11 / windows-latest py 3.11 latest PyQt5
- GitHub Check: Base py3.9 / ubuntu-24.04 py 3.9 latest PyQt5
- GitHub Check: Base py3.11 / ubuntu-24.04 py 3.11 latest PyQt5
- GitHub Check: Base py3.12 / ubuntu-24.04 py 3.12 latest PyQt5
- GitHub Check: Test PartSeg minimal / ubuntu-24.04 py 3.9 latest PyQt5
- GitHub Check: test_coverage / ubuntu-24.04 py 3.12 latest PyQt5
- GitHub Check: Test PartSeg conda
- GitHub Check: 4DNucleome.PartSeg (manifest_check manifest_check)
- GitHub Check: 4DNucleome.PartSeg (GetTestData linux)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check help)
- GitHub Check: 4DNucleome.PartSeg (Documentation_check Notebook_check)
- GitHub Check: 4DNucleome.PartSeg (formatting_check check_formating)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (41)
requirements/constraints_py3.9.txt (4)
18-18
: Dependency Update: attrs version bump
The version for the attrs package has been updated to 25.3.0. This change is consistent with similar updates in other constraints files. Please verify that all dependent modules continue to function as expected.
43-43
: Dependency Update: coverage version bump
The coverage package is now set to version 7.7.0. Ensure that the test suites and CI pipelines are compatible with this update.
238-238
: Dependency Update: partsegcore-compiled-backend upgrade
The upgrade to version 0.15.12 should be reviewed with particular attention to any compiled module integrations. A quick regression test is recommended.
353-353
: Dependency Update: pyzmq version bump
Updating pyzmq to 26.3.0 appears consistent with the overall dependency bump. Please confirm that no runtime messaging/API changes lead to issues.requirements/constraints_py3.9_pydantic_1.txt (4)
16-16
: Dependency Update: attrs version bump
The attrs version has been bumped to 25.3.0. This maintains consistency with the primary constraints file.
41-41
: Dependency Update: coverage version bump
Coverage is now at 7.7.0. Please ensure that the testing infrastructure remains fully compatible with this version.
236-236
: Dependency Update: partsegcore-compiled-backend upgrade
The update to 0.15.12 should be checked against features relying on compiled components. A brief smoke test is advised.
350-350
: Dependency Update: pyzmq version bump
The pyzmq package is updated to 26.3.0. Verify that no breaking API changes affect its usage in the project.requirements/constraints_py3.12_docs.txt (3)
16-16
: Dependency Update: attrs version bump
The attrs package has been updated to 25.3.0, aligning this docs constraint file with others.
168-168
: Dependency Update: numpy version bump
The numpy version is now 2.2.4. Although this is a minor version bump, please check that the documentation builds (and any image-related examples) are still functioning correctly.
395-395
: Dependency Update: tifffile version bump
Tifffile has been upgraded to 2025.3.13. Ensure that any image processing examples in the docs are validated against this release.requirements/constraints_py3.12.txt (6)
18-18
: Dependency Update: attrs version bump
Upgrading attrs to 25.3.0 helps maintain uniformity across Python version constraints. No issues are anticipated.
43-43
: Dependency Update: coverage version bump
Coverage has been updated to 7.7.0. Please run the test suites to confirm that there are no new incompatibilities.
179-179
: Dependency Update: numpy version bump
The numpy package is now 2.2.4—a minor update that should be backward compatible. Still, it is worth a quick check in numerical calculations.
228-228
: Dependency Update: partsegcore-compiled-backend upgrade
The upgrade to 0.15.12 should be validated especially for any functions that rely on compiled backend optimizations.
342-342
: Dependency Update: pyzmq version bump
With pyzmq now at 26.3.0, please ensure that existing message passing and related functionalities remain stable.
440-440
: Dependency Update: tifffile version bump
Tifffile has been updated to 2025.3.13. Confirm that image file operations and processing libraries work seamlessly with this version.requirements/constraints_py3.12_pydantic_1.txt (5)
16-16
: Dependency Update: attrs version bump
Aligning attrs to version 25.3.0 here ensures consistency with other pydantic constraints. No issues are expected.
41-41
: Dependency Update: coverage version bump
Coverage is now bumped to 7.7.0. Please run a quick verification with your test configuration to ensure no regressions.
226-226
: Dependency Update: partsegcore-compiled-backend upgrade
The backend compiled component has been updated to 0.15.12. Validate that this upgrade does not break any interactions with pydantic models relying on it.
339-339
: Dependency Update: pyzmq version bump
The upgrade to pyzmq 26.3.0 is noticed here as well. Testing for any API changes or deprecations is suggested.
437-437
: Dependency Update: tifffile version bump
Tifffile has been set to 2025.3.13 in this constraints file, aligning with other environments. Ensure that pydantic-integrated image processing remains unaffected.requirements/constraints_py3.11_pydantic_1.txt (2)
16-16
: Updatedattrs
to 25.3.0
The version bump from 25.1.0 to 25.3.0 is correctly applied. This change is in line with the coordinated update across environments.
41-41
: Updatedcoverage
to 7.7.0
The new version of coverage is applied consistently here.requirements/constraints_py3.10.txt (6)
18-18
: Updatedattrs
to 25.3.0
The new version is applied on line 18.
43-43
: Updatedcoverage
to 7.7.0
This update is present on line 43 and matches the coordinated update.
185-185
: Updatednumpy
to 2.2.4
Ensure that the Python 3.10 environment accepts the new numpy version without incompatibilities.
232-232
: Updatedpartsegcore-compiled-backend
to 0.15.12
This update is applied correctly.
349-349
: Updatedpyzmq
to 26.3.0
The version bump is correct.
445-445
: Updatedtifffile
to 2025.3.13
Review the release notes to ensure no breaking changes affect image processing integrations in PartSeg.requirements/constraints_py3.10_pydantic_1.txt (5)
16-16
: Updatedattrs
to 25.3.0
This change aligns with the other constraints files.
41-41
: Updatedcoverage
to 7.7.0
The updated version is applied as required.
232-232
: Updatedpartsegcore-compiled-backend
to 0.15.12
The dependency update is in line with the coordinated bump.
346-346
: Updatedpyzmq
to 26.3.0
The new version is applied correctly.
442-442
: Updatedtifffile
to 2025.3.13
Make sure to verify that the new tifffile version is compatible with any tools that depend on it.requirements/constraints_py3.11.txt (6)
18-18
: Updatedattrs
to 25.3.0
This change is applied correctly and is consistent with other files.
43-43
: Updatedcoverage
to 7.7.0
The new value is in place on line 43.
181-181
: Updatednumpy
to 2.2.4
Please verify that this version is fully compatible with the PartSeg modules under Python 3.11.
230-230
: Updatedpartsegcore-compiled-backend
to 0.15.12
The value is updated as expected.
347-347
: Updatedpyzmq
to 26.3.0
The change is applied correctly.
443-443
: Updatedtifffile
to 2025.3.13
Verify that any downstream image processing components are tested against this update.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1253 +/- ##
===========================================
+ Coverage 93.15% 93.16% +0.01%
===========================================
Files 210 210
Lines 33288 33288
===========================================
+ Hits 31009 31014 +5
+ Misses 2279 2274 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR is automatically created and updated by PartSeg GitHub
action cron to keep bundle dependencies modules up to date.
The updated packages are:
Summary by Sourcery
Chores:
Summary by CodeRabbit