Cherry-pick commits from master to managed-service branch #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to support luarocks v3 and also refactor Dockerfile to install luarocks and lua-rover directly from source
By default we run the prove task based on the number of available CPU cores. The nprocs test will return the number of available CPU cores in the docker executor VM, however the medium resource class only has access to 3 CPUs. So the prove task will always spawn more workers than the number of available CPU cores, which then causes the CPU to max out during the test and cause random errors.
tkan145
force-pushed
the
fapi-wrong-config-mas
branch
from
3ea813d to
39ebef8
Compare
|
This is targetting |
|
My bad, it's targeting |
|
This is doing far more than backport #1528, intended? |
|
This is tricky, when we decided to release the new managed-services release, I intentionally just fast forwarded right before all the konflux and luarock/lua-rover changes. But since then we have to
If you are ok with having the CI failing on this branch then I will just cherry-pick the fix alone. Otherwise we need to have back-port everything else except Konflux. WDTY? |
|
you add those changes to the description and reword the title and I will accept it and review. Deal? |
tkan145
changed the title
tkan145
changed the title
eguzki
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Port the following PR(s) to manged service branch
#1513
#1516
#1518
#1519
#1520
#1524
#1528
This is done mainly to fix issue reported in #1528. Cherry-pick commit instead of fast-foward due to concern raised here #1522 (review)