Skip to content

Commit

Permalink
feat: validate receiver in LimitOrderWithFee.fromDataAndExtension (#43
Browse files Browse the repository at this point in the history
)
  • Loading branch information
vbrvk authored Jan 29, 2025
1 parent bc76b20 commit c1d7caf
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/limit-order/limit-order-with-fee.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {UINT_40_MAX} from '@1inch/byte-utils'
import assert from 'assert'
import {FeeTakerExtension} from './extensions/fee-taker/fee-taker.extension'
import {LimitOrder} from './limit-order'
import {LimitOrderV4Struct, OrderInfoData} from './types'
Expand Down Expand Up @@ -37,6 +38,11 @@ export class LimitOrderWithFee extends LimitOrder {
const makerTraits = new MakerTraits(BigInt(data.makerTraits))
const feeExt = FeeTakerExtension.fromExtension(extension)

assert(
feeExt.address.equal(new Address(data.receiver)),
`invalid order: receiver must be FeeTaker extension address`
)

return new LimitOrderWithFee(
{
salt: BigInt(data.salt),
Expand Down

0 comments on commit c1d7caf

Please sign in to comment.