Исправления в работе с символами переменных #3226
Conversation
WalkthroughThe codebase has been refactored to simplify the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/AbstractVariableSymbol.java (6 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/IntBasedVariableSymbol.java (3 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/ShortBasedVariableSymbol.java (3 hunks)
- src/main/java/com/github/_1c_syntax/bsl/languageserver/providers/DocumentSymbolProvider.java (2 hunks)
Additional comments: 6
src/main/java/com/github/_1c_syntax/bsl/languageserver/providers/DocumentSymbolProvider.java (2)
48-48: The inclusion of
VariableKind.LOCALin thesupportedVariableKindsset is consistent with the PR's objective to handle local variable symbols correctly.68-68: The addition of a filter in the
toDocumentSymbolmethod to check for supported children symbols is a good practice to ensure that only relevant symbols are processed. This change should improve the accuracy of the symbol tree output.src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/IntBasedVariableSymbol.java (1)
- 78-78: The constructor of
IntBasedVariableSymbolhas been updated to remove thechildrenparameter, which aligns with the removal of the "children" field in theAbstractVariableSymbolclass. This change is consistent with the PR's objective to simplify the variable symbol structure.src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/ShortBasedVariableSymbol.java (1)
- 78-78: The constructor of
ShortBasedVariableSymbolhas been updated to remove thechildrenparameter, which is consistent with the changes in theAbstractVariableSymbolclass and the PR's objective to streamline the representation of variable symbols.src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/AbstractVariableSymbol.java (2)
49-49: Excluding the "parent" field from the
@ToStringannotation inAbstractVariableSymbolis a good practice to avoid potential issues with recursive toString calls, which can lead to stack overflow errors.93-95: The
getChildrenmethod now returns an empty list, which is consistent with the removal of the "children" field. This change simplifies the class structure and is in line with the PR's objectives.
Qodana Community for JVM17 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
|
Описание
Оптимизация лэйаута символов переменных, исправление вывода дерева символов
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно
Summary by CodeRabbit
Refactor
Bug Fixes