Skip to content

Conversation

cze-aeb
Copy link
Contributor

@cze-aeb cze-aeb commented Oct 6, 2024

Fixes the bug that ItemBuilder drops labels of URLs when using ItemBuilder.addUrl

Fixes #119

Copy link
Contributor

github-actions bot commented Oct 6, 2024

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@cze-aeb cze-aeb force-pushed the bugfix/builder-preserve-url-label branch from 87cb0bb to ca8aaa6 Compare October 6, 2024 20:44
@cze-aeb cze-aeb force-pushed the bugfix/builder-preserve-url-label branch from ca8aaa6 to 2922421 Compare April 22, 2025 04:23
@cze-aeb cze-aeb force-pushed the bugfix/builder-preserve-url-label branch from 2922421 to 00a6b46 Compare April 22, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ItemBuilder.addUrl drops label of ItemUrls
1 participant