Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve translation and replace images with English versions #13

Open
wants to merge 1 commit into
base: i18n/en
Choose a base branch
from

Conversation

guqing
Copy link
Member

@guqing guqing commented Feb 28, 2025

What this PR does?

improve translation and replace images with English versions

Before:

image

After:
image

Copy link

f2c-ci-robot bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member Author

guqing commented Feb 28, 2025

/release-note-none

@guqing guqing added the documentation Improvements or additions to documentation label Feb 28, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 28, 2025

Deploying maxkb-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: decca73
Status: ✅  Deploy successful!
Preview URL: https://09f215e1.maxkb-docs.pages.dev
Branch Preview URL: https://docs-nav.maxkb-docs.pages.dev

View logs

@guqing guqing requested review from wan92hen and baixin513 March 3, 2025 02:40
@wan92hen
Copy link
Collaborator

wan92hen commented Mar 3, 2025

Development 文档重复了

@guqing
Copy link
Member Author

guqing commented Mar 4, 2025

Development 文档重复了

good catch, 已修复

@wan92hen wan92hen changed the title docs: update mkdocs.yml navigation for comprehensive documentation structure WIP: docs: update mkdocs.yml navigation for comprehensive documentation structure Mar 4, 2025
Copy link
Collaborator

@wan92hen wan92hen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未进行文本翻译、图片替换的内容,不建议合并

@guqing
Copy link
Member Author

guqing commented Mar 4, 2025

未进行文本翻译、图片替换的内容,不建议合并

这的分步骤进行吧 要在一个 PR 中做吗

@wan92hen
Copy link
Collaborator

wan92hen commented Mar 4, 2025

未进行文本翻译、图片替换的内容,不建议合并

这的分步骤进行吧 要在一个 PR 中做吗

因为合并到这个分支后就会更新线上文档,可以将未处理的部分先去掉或者提到其他分支上

@guqing guqing changed the title WIP: docs: update mkdocs.yml navigation for comprehensive documentation structure WIP: docs: improve translation and replace images with English versions Mar 5, 2025
@guqing guqing changed the title WIP: docs: improve translation and replace images with English versions docs: improve translation and replace images with English versions Mar 5, 2025
@guqing
Copy link
Member Author

guqing commented Mar 5, 2025

Ready for review

@guqing guqing requested a review from wan92hen March 5, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants